Created attachment 346815 [details] [review]
h264parse: Include `interlace-mode` in caps

Those are the rules:

In the SPS:
  * if frame_mbs_only_flag=1 => all frame progressive
  * if frame_mbs_only_flag=0 => field_pic_flag defines if each frame is
    progressive or interlaced, thus the mode is 'mixed' in GStreamer
    terms.

Review of attachment 346815 [details] [review]:

::: gst/videoparsers/gsth264parse.c
@@ +1872,3 @@
+
+      gst_caps_set_simple (caps, "interlace-mode", G_TYPE_STRING,
+          gst_video_interlace_mode_to_string (imode), NULL);

Actually no. You should prefer what upstream has given in the caps, if anything, and only otherwise set your own value

(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 346815 [details] [review] [review]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1872,3 @@
> +
> +      gst_caps_set_simple (caps, "interlace-mode", G_TYPE_STRING,
> +          gst_video_interlace_mode_to_string (imode), NULL);
> 
> Actually no. You should prefer what upstream has given in the caps, if
> anything, and only otherwise set your own value

Indeed, missed that, on it.

Created attachment 346818 [details] [review]
h264parse: Include `interlace-mode` in caps

Those are the rules:

In the SPS:
  * if frame_mbs_only_flag=1 => all frame progressive
  * if frame_mbs_only_flag=0 => field_pic_flag defines if each frame is
    progressive or interlaced, thus the mode is 'mixed' in GStreamer
    terms.

commit b75a61342f4ea039d922a966f36b02cd9d9c3ad8
Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Mon Feb 27 10:32:45 2017 -0300

    h264parse: Include `interlace-mode` in caps
    
    Those are the rules:
    
    In the SPS:
      * if frame_mbs_only_flag=1 => all frame progressive
      * if frame_mbs_only_flag=0 => field_pic_flag defines if each frame is
        progressive or interlaced, thus the mode is 'mixed' in GStreamer
        terms.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=779309