GNOME Bugzilla – Bug 779241
build-preferences: give some spacing between entry border and text
Last modified: 2017-03-07 03:08:32 UTC
Created attachment 346732 [details] Build preferences (image) In Build preferences (Alt-,) Give some space b/w entry border and the filled in text below Environment variable settings. Thanks
Created attachment 347107 [details] [review] build-prefrences: give some spacing between entry borner and text There was no padding between the border and the text input in Build Prefrences. To fix this problem the padding was changed from 0 to 10px.
Created attachment 347108 [details] Fix of Build preferences (image)
Review of attachment 347107 [details] [review]: I think there is too much padding now in the row due to the additional size required in the entry. Is there something we can do with border-shadow or outline that can allow us to add padding between the entry text and the border, but not increase the size of the row?
Created attachment 347111 [details] Fix of Build preferences 2 (image)
Yes, I can do that. So the text stays in the same position, just the border moves. (see Fix of Build preferences 2)
(In reply to Lucie Dvorakova from comment #5) > Yes, I can do that. So the text stays in the same position, just the border > moves. (see Fix of Build preferences 2) Yeah that looks better
Created attachment 347118 [details] [review] build-prefrences: readjust the spacing between entry border and text Readjusted the padding so the row size stays the same
Created attachment 347166 [details] borders to shrink Can you reduce the borders on the three sides with the red dots so that they match the left border? That should help reduce the row height, and then we can apply this to the rest of preferences/configuration widgets. Also, when posting new patches, remember to obsolete the previous patches (and upload a new "combined" patch if that is necessary). That allows me to more quickly review them without having to open up multiple files and merge them in my head :)
Created attachment 347240 [details] [review] build-preferences: give some spacing between entry border and text There was no padding between the border and the text input in Build Preferences. The border was moved to create the wanted space.
Created attachment 347358 [details] [review] build-preferences: give some spacing between entry border and text There was no padding between the border and the text input in Build Preferences. The border was moved to create the wanted space.
(In reply to Lucie Dvorakova from comment #9) > Created attachment 347240 [details] [review] [review] > build-preferences: give some spacing between entry border and text > > There was no padding between the border and the text input in Build > Preferences. The border was moved to create the wanted space. Looks good, I've updated the patch to apply to preferences as well as the configurationview.
Attachment 347358 [details] pushed as 5f2ba22 - build-preferences: give some spacing between entry border and text