After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779138 - webrtcdsp: expose voice activity detection.
webrtcdsp: expose voice activity detection.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 1.12.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-23 15:14 UTC by Mathieu Duponchelle
Modified: 2017-06-02 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
webrtcdsp: expose voice activity detection. (8.23 KB, patch)
2017-02-23 15:14 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-02-23 15:14:13 UTC 
The element now exposes properties to enable and configure
voice activity detection, and posts "voice-activity" messages
when the return value of stream_has_voice () changes.
Comment 1 Mathieu Duponchelle 2017-02-23 15:14:18 UTC 
Created attachment 346580 [details] [review]
webrtcdsp: expose voice activity detection.
Comment 2 Nicolas Dufresne (ndufresne) 2017-03-07 16:55:16 UTC 
Review of attachment 346580 [details] [review]:

Looks good to me. Just have a small question below, nothing important really. One note, if the VAD buffer size it's not a multiple of 10ms, our message timestamp will be slightly off. Maybe we should document ? Otherwise it's good for merging.

::: ext/webrtcdsp/gstwebrtcdsp.cpp
@@ +624,3 @@
+  if (self->voice_detection) {
+    GEnumClass *likelihood_class = (GEnumClass *)
+        g_type_class_ref (GST_TYPE_WEBRTC_VOICE_DETECTION_LIKELIHOOD);

Considering this type is used for a property, I'm wondering if using g_type_class_peek() could be sufficient (mostly a curiosity).
Comment 3 Nicolas Dufresne (ndufresne) 2017-03-28 01:14:46 UTC 
Some local testing showed that it does not work if voice-detection-frame-size-ms is bigger of equal to 20ms. Do you know why ? Shall we document ?
Comment 4 Nicolas Dufresne (ndufresne) 2017-03-28 01:18:57 UTC 
Comment on attachment 346580 [details] [review]
webrtcdsp: expose voice activity detection.

Leaving open so we can investigate if it's a library bug or our bug.

Attachment 346580 [details] pushed as fc261bc - webrtcdsp: expose voice activity detection.
Comment 5 Nicolas Dufresne (ndufresne) 2017-06-02 19:35:45 UTC 
Let's assume it's library limitation.