After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779105 - Cannot highlight more than one search term
Cannot highlight more than one search term
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client
master
Other Linux
: High normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
wk2-fallout
Depends on:
Blocks:
 
 
Reported: 2017-02-23 00:39 UTC by Michael Gratton
Modified: 2019-03-08 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Gratton 2017-02-23 00:39:56 UTC
The WebKit2 API has changed how find works, making it difficult to highlight more than one search term.

Need to investigate how to convince it to do so, either using the new WK2 or by doing highlighting manually.
Comment 1 Federico Bruni 2017-02-28 16:03:31 UTC
Nitpicking... If two or more search keywords are close to each other, both words are highlighted. The problem is when they are not close to each other.
Comment 2 Michael Gratton 2018-04-14 06:49:02 UTC
This will probably require our own custom JS implementation, since neither the WebKitGTK API nor the DOM provides anything useful — Neither window.find() nor execCommand("findString") supports multiple string matching and neither are standardised, and the FindText API https://www.w3.org/TR/findtext/ is neither finalised nor implemented.

As such this requires some substantial work and hence won't make 0.12.
Comment 3 Michael Gratton 2019-03-08 21:51:56 UTC
Closing in favour of https://gitlab.gnome.org/GNOME/geary/issues/305