After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779078 - Adwaita: last treeview header button adds border on hover
Adwaita: last treeview header button adds border on hover
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-02-22 16:24 UTC by Sebastian Keller
Modified: 2017-05-17 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adwaita: Avoid accidental border on the last treeview header button (2.62 KB, patch)
2017-02-22 16:24 UTC, Sebastian Keller
none Details | Review

Description Sebastian Keller 2017-02-22 16:24:24 UTC
Created attachment 346463 [details] [review]
adwaita: Avoid accidental border on the last treeview header button

Hovering the last treeview header button causes a right border to be added to it. This causes the treeview size to change and thus can result in the content of that column being shifted around or a scrollbar to appear. Both can be seen in sysprof for example.

This is because the :hover selector overrides the :last-child selector which is supposed to hide this border. This is fixed by adding an additional :last-child:hover selector that overrides :hover again. I've done the same for :active, but I'm not sure if this is strictly necessary.

This bug affects both master and gtk-3-22.
Comment 1 Lapo Calamandrei 2017-05-16 16:17:03 UTC
Good catch, I'd rather move the :last-child selector after the :hover overriding it instead of adding more specific selectors though
Comment 2 Lapo Calamandrei 2017-05-17 16:16:52 UTC
Pushed a fix to master and 3-22 branch, closing.