GNOME Bugzilla – Bug 779075
Re-align and desaturate the supply level bar
Last modified: 2017-02-26 11:53:36 UTC
.
Created attachment 346457 [details] [review] printers: Resize the supply level bar Make the supply level bar size, margin, border, and background match the mockups at https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines
Created attachment 346458 [details] [review] printers: Fill the supply_frame background when supply is empty According to the mockups at https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines The supply level bar should have a grey background when there are no colors in the supply bar. This patch sets the "background" css name to the supply_frame when there's not a single color in the supply bar.
Created attachment 346459 [details] [review] printers: Desaturate the supply level colors Even though we would obtain primary colors by querying the printer supply info, it is more eye-candy to desaturate (tone down) the colors in the UI. These changes are according to the mockups of the new Printers panel at https://wiki.gnome.org/Design/SystemSettings/Printers
(In reply to Felipe Borges from comment #3) > Created attachment 346459 [details] [review] [review] > printers: Desaturate the supply level colors > > Even though we would obtain primary colors by querying the printer > supply info, it is more eye-candy to desaturate (tone down) the > colors in the UI. > > These changes are according to the mockups of the new Printers > panel at https://wiki.gnome.org/Design/SystemSettings/Printers jimmac suggested that we should tone down the colors a bit.
Thank you for the patches but they need some tweak still. First thing which needs to change is the way you "tone down" the colors. You have to transform the colors to HSV model, do the change there and convert them back to RGB then. I suggest 0.6 ratio for saturation and 0.9 for value. Another thing is that the bar misses borders which are there thanks to the initial position of (3.5, 3.5) now. I suggest to draw the inner part of the rectangle by the toned down color and draw a 1 pixel wide border around that after with again toned down color (use ratio 0.85 on value of the fill color). This way it will look really better.
Created attachment 346626 [details] [review] printers: Tweak the printer supply level bar Make the supply level bar size, margin, border, background, and saturation match the mockups at https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines Even though we would obtain primary colors by querying the printer supply info, it is more eye-candy to desaturate (tone down) the colors in the UI.
Created attachment 346627 [details] [review] printers: Fill the supply_frame background when supply is empty According to the mockups at https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines The supply level bar should have a grey background when there are no colors in the supply bar. This patch sets the "background" css name to the supply_frame when there's not a single color in the supply bar.
Created attachment 346628 [details] screenshot
Review of attachment 346626 [details] [review]: Thank you for the patch. Please ask for freeze break and push it to master if accepted.
Review of attachment 346627 [details] [review]: This one too. Thanks.
These UI freeze exceptions were authorized by the release-team https://mail.gnome.org/archives/release-team/2017-February/msg00045.html Attachment 346626 [details] pushed as 2c7fc86 - printers: Tweak the printer supply level bar Attachment 346627 [details] pushed as 86c028f - printers: Fill the supply_frame background when supply is empty