After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779021 - Application should have its own icon
Application should have its own icon
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-21 13:23 UTC by Bastien Nocera
Modified: 2017-06-30 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icons: provide app icon (392.33 KB, patch)
2017-02-27 17:51 UTC, Jakub Steiner 		none Details | Review
icons: provide app icon (392.33 KB, patch)
2017-06-27 10:15 UTC, Jakub Steiner 		none Details | Review

Description Bastien Nocera 2017-02-21 13:23:58 UTC 
gnome-contacts currently uses Icon=x-office-address-book which would be provided by the theme.

Except that the Adwaita icon theme only provides a colourful 48x48 icon, which looks bad:
$ locate -e x-office-address-book | grep /usr/share | grep Adwaita
/usr/share/icons/Adwaita/16x16/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/16x16/mimetypes/x-office-address-book.png
/usr/share/icons/Adwaita/22x22/mimetypes/x-office-address-book.png
/usr/share/icons/Adwaita/24x24/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/24x24/mimetypes/x-office-address-book.png
/usr/share/icons/Adwaita/32x32/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/32x32/mimetypes/x-office-address-book.png
/usr/share/icons/Adwaita/48x48/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/48x48/mimetypes/x-office-address-book.png
/usr/share/icons/Adwaita/64x64/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/96x96/mimetypes/x-office-address-book-symbolic.symbolic.png
/usr/share/icons/Adwaita/scalable/mimetypes/x-office-address-book-symbolic.svg
Comment 1 Jakub Steiner 2017-02-27 17:51:49 UTC 
Created attachment 346846 [details] [review]
icons: provide app icon

- hicolor in up to 512x512px
- symbolic
Comment 2 Niels De Graef 2017-06-20 10:57:06 UTC 
Review of attachment 346846 [details] [review]:

Needs just two trivial changes to make it work:

* you specify the 256x256 size in data/icons/Makefile.am, but forgot to generate it as a file.
* vice-versa for the 256x256 icon.

Rest looks good though :)
Comment 3 Niels De Graef 2017-06-20 10:58:06 UTC 
Correction: the 2nd bullet is about 521x521
Comment 4 Bastien Nocera 2017-06-27 10:09:40 UTC 
(In reply to Niels De Graef from comment #3)
> Correction: the 2nd bullet is about 521x521

512x512 ;)
Comment 5 Jakub Steiner 2017-06-27 10:15:49 UTC 
Created attachment 354553 [details] [review]
icons: provide app icon

- hicolor in up to 512x512px
- symbolic
Comment 6 Niels De Graef 2017-06-27 10:28:56 UTC 
(In reply to Jakub Steiner from comment #5)
> Created attachment 354553 [details] [review] [review]
> icons: provide app icon
> 
> - hicolor in up to 512x512px
> - symbolic
Hi Jakub, is it possible you accidentally uploaded the same patch? :-)


(In reply to Bastien Nocera from comment #4)
> (In reply to Niels De Graef from comment #3)
> > Correction: the 2nd bullet is about 521x521
> 
> 512x512 ;)
:p
Comment 7 Jakub Steiner 2017-06-30 13:05:18 UTC 
Unlike the previous patch, the Makefile now correctly lists the 512x512px size.
Comment 8 Niels De Graef 2017-06-30 13:10:46 UTC 
(In reply to Jakub Steiner from comment #7)
> Unlike the previous patch, the Makefile now correctly lists the 512x512px
> size.
My bad! That was on error on my part indeed.

Landed on master as commit e1c2ab029a404030555a51e6344a3c285173b77c.

Jakub: thanks a lot!