GNOME Bugzilla – Bug 779009
Missing property-change::accessible-description events when the tooltip is used as description
Last modified: 2017-12-10 02:25:41 UTC
Created attachment 346310 [details] [review] Fix updating the widget accessible description when using its tooltip The the widget tooltip is used as the accessible description, the property-change::accessible-description event should be fired when the tooltip changes as `get_description()` will give a different result. Attached patch fixes it.
Created attachment 346311 [details] [review] Fix updating the widget accessible description when using its tooltip (GTK+2 version) GTK 2.24 version of the patch
Review of attachment 346310 [details] [review]: fwiw, it makes perfect sense to me, though I'd quibble about the comment: ::: gtk/a11y/gtkwidgetaccessible.c @@ +485,3 @@ widget); + + /* As we return custom description in get_description(), notify I think something like this would be clearer: "If the accessible has no specific description, :accessible-description gets the tooltip text, so notify that the observed value has changed."
Created attachment 362086 [details] [review] proposed fix
Created attachment 362087 [details] [review] proposed fix (gtk2)
Hello, Any news on this? FWIW, I have attached versions of the gtk3 and gtk2 patches with the proposed comment improvement. Samuel
Created attachment 362088 [details] [review] proposed fix (gtk2)
Review of attachment 362086 [details] [review]: I think the comment in the code is unnecessary. Ok to push without it
Review of attachment 362088 [details] [review]: same here
Created attachment 362490 [details] [review] proposed fix
Created attachment 362491 [details] [review] proposed fix (gtk2) Here are the patches without the comment.
Review of attachment 362490 [details] [review]: .
Review of attachment 362491 [details] [review]: .
Attachment 346310 [details] pushed as 6934432 - Fix updating the widget accessible description when using its tooltip