After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778991 - Plug a mem leak in gdbusauth
Plug a mem leak in gdbusauth
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.51.x
Other Mac OS
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-02-21 01:18 UTC by Ole André Vadla Ravnås
Modified: 2017-02-21 10:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdbusauth: plug memory leak (1.09 KB, patch)
2017-02-21 01:24 UTC, Ole André Vadla Ravnås 		committed Details | Review

Description Ole André Vadla Ravnås 2017-02-21 01:18:04 UTC 
This happens for the following state transition:

SERVER_STATE_WAITING_FOR_AUTH
  |
  v
G_DBUS_AUTH_MECHANISM_STATE_REJECTED
  |
  v
SERVER_STATE_WAITING_FOR_AUTH

Where the previous `mech` gets overwritten.
Comment 1 Ole André Vadla Ravnås 2017-02-21 01:24:15 UTC 
Created attachment 346293 [details] [review]
gdbusauth: plug memory leak
Comment 2 Ole André Vadla Ravnås 2017-02-21 01:29:00 UTC 
Tracked down using Frida, a dynamic instrumentation toolkit powered by GLib:
https://gist.github.com/oleavr/a845ca9839d74c5dd2e34ef976d0d9b6
Comment 3 Philip Withnall 2017-02-21 10:30:32 UTC 
Review of attachment 346293 [details] [review]:

Good catch, thanks.
Comment 4 Philip Withnall 2017-02-21 10:32:34 UTC 
Attachment 346293 [details] pushed as 8693d60 - gdbusauth: plug memory leak