After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778983 - Move number parsing to engine/qof
Move number parsing to engine/qof
Status: RESOLVED OBSOLETE
Product: GnuCash
Classification: Other
Component: Import - CSV
git-master
Other All
: Normal minor
: ---
Assigned To: gnucash-import-maint
gnucash-import-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-20 21:36 UTC by Geert Janssens
Modified: 2018-06-29 23:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Geert Janssens 2017-02-20 21:36:55 UTC 
The csv importer has code to convert strings into numbers (GncNumerics). This code is using xaccPrintAmount. However with c++/boost we have potentially much more powerful number parsers available. The idea is to leverage GncNumeric's tostring or input stream feature to do the heavy lifting. Perhaps a preparsing function needs to be added still.
By moving this code into the engine/qof, other importers will be able to use it as well.
Comment 1 Geert Janssens 2017-04-28 09:58:17 UTC 
One of the limitations of current xaccPrintAmount is it fails to parse numbers with a trailing negative sign. Hopefully we can fix this by moving to c++/boost.
Comment 2 John Ralls 2018-06-29 23:54:45 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. The new URL for this bug is https://bugs.gnucash.org/show_bug.cgi?id=778983. Please continue processing the bug there and please update any external references or bookmarks.