After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778977 - Better notificatons for different cases leading to the closing of a draft
Better notificatons for different cases leading to the closing of a draft
Status: RESOLVED DUPLICATE of bug 795219
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-20 20:27 UTC by Frank
Modified: 2018-04-13 03:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Frank 2017-02-20 20:27:33 UTC
When I have an unsaved mail open, I get the following notifications:
• Clicking on "close and save" ⇒ Saving draft with no notification
• Clicking on another mailbox folder or mail ⇒ "Close open drafts? (Close/Abort)"

When I have a draft open, I get the following:
• Clicking on "close and save" ⇒ "Do you want to discard the message (yes/no)"
• Clicking on another mailbox folder or mail ⇒ "Close open drafts? (Close/Abort)"


The notification of the third case is completely wrong and should just save as in the first case. The notifications of the second and fourth case should provide the opportunities to save, discard changes and abort (in my opinion).
Comment 1 Gautier Pelloux-Prayer 2017-02-20 21:22:27 UTC
Hello Frank,

It might be related to Bug 747627 where we discussed a long time about it. I had to open a bug for it but did not so this bug is, I believe, the core of the issue. 

First, on which version did you test? You marked "master" but I believe it's not, since "Close and Save" button is now "Save and Close". You can see the version in the About page.
Comment 2 Frank 2017-02-20 22:31:34 UTC
Sorry, it's 0.11.3 (on Fedora 25 with Gnome 3.22.2 and GTK+ 3.22.8).

My bug report is not about disappearing drafts after clicking "save", but about correct (case 3) and better (case 2 & 4) notifications/actions/questions.
Comment 3 Federico Bruni 2017-12-20 00:09:43 UTC
Case 3 seems weird.
Did you check that Drafts special folder has been correctly detected by Geary? Double-check the sidebar before saving and expand the Labels to see if there's something wrong.

Case 2 and 4: you want to add the Save option in the dialog beside Cancel and Close. It makes sense and it's a trivial fix, if there's consensus for it.

BTW, see Bug 730607 - "Close open draft messages?" dialog should be singular for single inline composer
Comment 4 Michael Gratton 2018-04-13 03:27:33 UTC
To be honest, I think we should keep the composer open in case #2 & #4 - just drop it down to being a half screen and load the different conversation above it. I find quite often having to go looking for a different conversation when composing a message and at the moment it's really annoying to have to detach then go looking for it. I've filed Bug 795219 to cover that.

This just leaves case #3, which I currently can't reproduce, and believe has been fixed in 0.12.

Frank can you test #3 out in 0.12 and reopen this if that is still a problem for you. Thanks!

*** This bug has been marked as a duplicate of bug 795219 ***