After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778831 - display: Check we have a screen before freeing it
display: Check we have a screen before freeing it
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-17 13:31 UTC by Florian Müllner
Modified: 2017-02-19 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Check we have a screen before freeing it (1.06 KB, patch)
2017-02-17 13:31 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-02-17 13:31:29 UTC
See patch.
Comment 1 Florian Müllner 2017-02-17 13:31:36 UTC
Created attachment 346072 [details] [review]
display: Check we have a screen before freeing it

The reason for the display to be closed may be meta_screen_new()
returning NULL, in which case we don't have a screen to free.
Avoid a segfault on exit by adding a proper check.
Comment 2 Rui Matos 2017-02-19 19:25:56 UTC
Review of attachment 346072 [details] [review]:

ok
Comment 3 Florian Müllner 2017-02-19 19:57:08 UTC
Attachment 346072 [details] pushed as e1ffe15 - display: Check we have a screen before freeing it