After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778779 - providers: improve spacing
providers: improve spacing
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-02-16 17:24 UTC by Georges Basile Stavracas Neto
Modified: 2017-02-17 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
providers: improve spacing (2.43 KB, patch)
2017-02-16 17:24 UTC, Georges Basile Stavracas Neto 		accepted-commit_now Details | Review
providers: Improve spacing (2.18 KB, patch)
2017-02-17 11:41 UTC, Debarshi Ray 		committed Details | Review
providers: Use GtkContainer API instead of GtkBox (1.23 KB, patch)
2017-02-17 11:41 UTC, Debarshi Ray 		committed Details | Review

Description Georges Basile Stavracas Neto 2017-02-16 17:24:35 UTC 
Per Allan's request, improve the spacing between UI elements.
Comment 1 Georges Basile Stavracas Neto 2017-02-16 17:24:39 UTC 
Created attachment 345972 [details] [review]
providers: improve spacing
Comment 2 Debarshi Ray 2017-02-17 11:40:57 UTC 
Review of attachment 345972 [details] [review]:

::: src/goabackend/goaprovider.c
@@ +1632,3 @@
       gtk_label_set_xalign (GTK_LABEL (label), 0.0);
+
+      gtk_container_add (GTK_CONTAINER (hbox), label);

Nitpick: This seems more like a stylistic change. Let's do it in a separate commit.
Comment 3 Debarshi Ray 2017-02-17 11:41:31 UTC 
Created attachment 346057 [details] [review]
providers: Improve spacing
Comment 4 Debarshi Ray 2017-02-17 11:41:56 UTC 
Created attachment 346058 [details] [review]
providers: Use GtkContainer API instead of GtkBox
Comment 5 Debarshi Ray 2017-02-17 11:42:34 UTC 
Georges, please push to master after ensuring that I haven't messed it up.
Comment 6 Georges Basile Stavracas Neto 2017-02-17 13:40:24 UTC 
Thanks for the reviews! Both patches work fine.

Attachment 346057 [details] pushed as e340eb0 - providers: Improve spacing
Attachment 346058 [details] pushed as db4567e - providers: Use GtkContainer API instead of GtkBox