After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778748 - Pressing 'Escape' key sets the shortcut
Pressing 'Escape' key sets the shortcut
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
git master
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-16 08:41 UTC by Mohammed Sadiq
Modified: 2017-04-27 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: discard the added shortcut on Escape (1.12 KB, patch)
2017-02-21 05:21 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-02-16 08:41:40 UTC 
In keyboard shortcuts, when the user modifies some shortcut and add some key combination. And later press 'Escape' key, the modified shorcut key is set, which should not (As it is explicitly said to press Esc key to cancel).
Comment 1 Mohammed Sadiq 2017-02-21 05:21:06 UTC 
Created attachment 346301 [details] [review]
keyboard: discard the added shortcut on Escape

If the user press Escape key after the user have set some shortcut,
don't save the newly set shortcut, and close the dialog.
Comment 2 Georges Basile Stavracas Neto 2017-03-02 18:27:18 UTC 
Review of attachment 346301 [details] [review]:

Looks good.
Comment 3 Georges Basile Stavracas Neto 2017-04-27 13:22:29 UTC 
Thanks for the patch!

Attachment 346301 [details] pushed as eeddf497a - keyboard: Discard the added shortcut on Escape