GNOME Bugzilla – Bug 778554
MetaInputSettings: allow edge scrolling without 2fg capable devices
Last modified: 2017-02-16 15:53:07 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1419292
Created attachment 345624 [details] [review] MetaInputSettings: allow edge scrolling without 2fg capable devices We should only force edge scrolling off if two finger is enabled *and* we actually have two finger capable devices.
Review of attachment 345624 [details] [review]: One question, otherwise LGTM ::: src/backends/meta-input-settings.c @@ +497,2 @@ /* If both are enabled we prefer two finger. */ + if (edge_scroll_enabled && two_finger_scroll_enabled && two_finger_scroll_available) Is this sufficient, or do we also need to make sure that 2fg scroll is disabled?
(In reply to Florian Müllner from comment #2) > Is this sufficient, or do we also need to make sure that 2fg scroll is > disabled? If 2fg isn't available, disabling it is a nop. We don't allow both methods to be enabled at the same time because libinput doesn't allow it. But it does allow no scrolling so we allow users to disable both scroll methods in case that's what you mean. I'm not sure that's a good UX but it was like that before and is orthogonal to this issue.
(In reply to Rui Matos from comment #3) > (In reply to Florian Müllner from comment #2) > > Is this sufficient, or do we also need to make sure that 2fg scroll is > > disabled? > > If 2fg isn't available, disabling it is a nop. And so is enabling it I assume? What I meant to ask is: If both methods are enabled and we don't disable edge-scroll because 2fg scroll is unavailable, will we end up with the (illegal) setting of two conflicting methods being enabled at the same time?
(In reply to Florian Müllner from comment #4) > (In reply to Rui Matos from comment #3) > > If 2fg isn't available, disabling it is a nop. > > And so is enabling it I assume? Yes. > What I meant to ask is: If both methods are > enabled and we don't disable edge-scroll because 2fg scroll is unavailable, > will we end up with the (illegal) setting of two conflicting methods being > enabled at the same time? In gsettings, yes both might be enabled at the same time. g-c-c tries to avoid that case but people can set it some other way. But if that happens, the backend vfuncs that pass the values to libinput will refuse setting it because they also check if it's available.
Attachment 345624 [details] pushed as 9092390 - MetaInputSettings: allow edge scrolling without 2fg capable devices