GNOME Bugzilla – Bug 778458
User accounts design review
Last modified: 2017-05-03 08:36:33 UTC
Some miscellaneous issues I spotted when reviewing the updated user accounts panel: • Sometimes, when there are two accounts, switching between accounts causes the controls to move up/down and left/right - https://dl.dropboxusercontent.com/u/5031519/settings/Screencast%20from%2010-02-17%2015%3A39%3A53.webm • The button for changing the profile picture has a little arrow in the corner, which doesn't look great. It would probably be better to drop the arrow and give the button a raised appearance. This will be more noticeable too. • We say "Add User" but "Remove Account" - the latter should probably be "Remove User" to match.
Created attachment 345569 [details] [review] user-accounts: Drop the user photo selector arrow
Created attachment 345570 [details] [review] user-accounts: Remove button label to "Remove User" "Remove User" matches better to "Add User" than "Remove Account".
Created attachment 345571 [details] [review] user-accounts: Save vertical space in the alignment of widgets Compensate border-width changes with respective margins.
Created attachment 345572 [details] [review] user-account: Use a stack in user-icon to keep the same size This fixes the undesired jumps (resizes) while switching between "Your Account" and any other account.
Created attachment 345573 [details] [review] user-accounts: Re-label "Remove Account" button to "Remove User" "Remove User" matches better to "Add User" than "Remove Account".
Review of attachment 345569 [details] [review]: Looks good to me!
Review of attachment 345571 [details] [review]: ::: panels/user-accounts/data/user-accounts-dialog.ui @@ +436,3 @@ <property name="valign">GTK_ALIGN_END</property> + <property name="margin_bottom">20</property> + <property name="margin_end">20</property> I think we should use margin top here also, because the button is too close to the other options if font-scale is bigger than 1 (so the height_request is not enough).
Review of attachment 345572 [details] [review]: Looks good to me!
Review of attachment 345573 [details] [review]: Looks good to me!
Review of attachment 345572 [details] [review]: Just please change "user-account:" to "user-accounts:" before pushing...
Attachment 345569 [details] pushed as ffb2aaa - user-accounts: Drop the user photo selector arrow Attachment 345572 [details] pushed as 92e99f6 - user-account: Use a stack in user-icon to keep the same size Attachment 345573 [details] pushed as c1f56c3 - user-accounts: Re-label "Remove Account" button to "Remove User"
Attachment 345571 [details] pushed as da997dc - user-accounts: Save vertical space in the alignment of widgets
Created attachment 345612 [details] [review] patch Simple spacing patch
Created attachment 345613 [details] [review] patch - give the user image a raised appearance It would also be nice to make the button image bigger - say 96px - but I couldn't figure out how to do that without also increasing the size of the image in the carousel.
Review of attachment 345612 [details] [review]: cool.
Review of attachment 345613 [details] [review]: alright. designer and hacker :D
Created attachment 345615 [details] [review] user-accounts: Make user icon bigger User icon should be bigger as per mockup.
Review of attachment 345615 [details] [review]: thanks!
Attachment 345615 [details] pushed as 8e6fccc - user-accounts: Make user icon bigger
Created attachment 345701 [details] [review] user-accounts: Handle pixel-size changes Commit 8e6fccc introduced pixel-size handling for user icon, however, the icon is not resized on each pixel-size change as it should. This is not problem currently, but might be problem in the future...
Created attachment 345702 [details] [review] user-accounts: Simplify scale-factor handling Remove redundant on_scale_factor_changed function and call render_image function directly.
Review of attachment 345701 [details] [review]: sure.
Review of attachment 345702 [details] [review]: lgtm
Attachment 345701 [details] pushed as c09e8f5 - user-accounts: Handle pixel-size changes Attachment 345702 [details] pushed as 466264e - user-accounts: Simplify scale-factor handling