Created attachment 345091 [details] [review]
batch-rename: fix stack child height

With numbering added, the format mode stack child is slightly smaller
than the replace one, so the scrolled window height is slightly
changing when switching between modes.

To fix this, add a top margin to the numbering box, so that the two
stack children have the same size.

Review of attachment 345091 [details] [review]:

Well spotted!

This is not a good fix though, calibrating UI by pixel spacing is going to break any time (even changing the font). You need to rely on the code, making the two children the same size, regarding what size it is. For that you know the general solution, GtkSizeGroup.

However, there is also some general solution for some containers, which is called "homogeneus". Check the homogeneus property of the stack, and you will fix the problem :)

Created attachment 345139 [details] [review]
batch-rename: fix stack child height

With numbering added, the format mode stack child is slightly smaller
than the replace one, so the scrolled window height is slightly
changing when switching between modes.

The problem is that the row spacing in the replace stack child is
greater by 1px than the spacing in the format stack child.

To fix this make the replace stack child have the same row spacing.

Review of attachment 345139 [details] [review]:

yeah!

Attachment 345139 [details] pushed as 76cefc8 - batch-rename: fix stack child height