GNOME Bugzilla – Bug 778174
raw: Fix the chromatic aberration and gamma curve setting
Last modified: 2017-02-06 18:54:25 UTC
I see two problems in the way LibRaw is set up in configure_for_rgb_display. One, libraw_output_params_t.gamm[0] is meant to have the inverted gamma or power value. See: http://www.libraw.org/docs/API-datastruct-eng.html#libraw_output_params_t Second, looking at the generated C code, the way set_chromatic_aberrations and set_gamma_curve are called seems wrong. We are passing libraw_output_params_t by value, instead of by reference / pointer. However my familiarity with Vala is limited, so I don't know how to fix it.
Created attachment 344930 [details] [review] libraw.vapi: Set the correct power value for the gamma curve
Created attachment 344934 [details] [review] graw, libraw.vapi: Use the correct type for use_camera_matrix Found a third problem.
Attachment 344930 [details] pushed as e045b9b - libraw.vapi: Set the correct power value for the gamma curve Attachment 344934 [details] pushed as 6c6182f - graw, libraw.vapi: Use the correct type for use_camera_matrix
Created attachment 345049 [details] [review] libraw.vapi: Fix setting of parameters on OutputParams Signed-off-by: Jens Georg <mail@jensge.org>
Comment on attachment 345049 [details] [review] libraw.vapi: Fix setting of parameters on OutputParams Attachment 345049 [details] pushed as c73d7b5 - libraw.vapi: Fix setting of parameters on OutputParams This should fix the wrong C code.