After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777872 - Don't use Primary+x (Ctrl + x) shortcut for exporting bookmarks
Don't use Primary+x (Ctrl + x) shortcut for exporting bookmarks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-28 15:47 UTC by Tomas Popela
Modified: 2017-01-28 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix conflicting keyboard shortcut (1.50 KB, patch)
2017-01-28 18:25 UTC, Iulian Radu 		committed Details | Review

Description Tomas Popela 2017-01-28 15:47:20 UTC 
SSIA. This shortcut is used for clipboard cut. I would suggest to don't use any shortcut for this action as it is not used so often.

https://git.gnome.org/browse/epiphany/tree/src/resources/gtk/application-menu.ui#n33
Comment 1 Michael Catanzaro 2017-01-28 17:26:07 UTC 
Wow :(
Comment 2 Iulian Radu 2017-01-28 18:25:47 UTC 
Created attachment 344463 [details] [review]
Fix conflicting keyboard shortcut

Bookmarks export uses ctrl + x as a keyboard shortcut, which is also
used for clipboard cut.

Replace bookmarks export shortcut it with Ctrl + Shift + x. For
consistency, also replace bookmarks import with Ctrl + Shift + m.


My bad, sorry. Is this conflicting with anything I'm unaware of?
Comment 3 Michael Catanzaro 2017-01-28 19:19:13 UTC 
Review of attachment 344463 [details] [review]:

I don't think so. Looks good.
Comment 4 Iulian Radu 2017-01-28 19:22:40 UTC 
Attachment 344463 [details] pushed as 46e0e29 - Fix conflicting keyboard shortcut