After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777869 - Letterbox photo thumbnails
Letterbox photo thumbnails
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on: 779032 779073
Blocks:
 
 
Reported: 2017-01-28 11:43 UTC by Allan Day
Modified: 2017-03-02 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils: Short-circuit larger GdkPixbufs when centering (1.30 KB, patch)
2017-02-21 18:54 UTC, Debarshi Ray 		committed Details | Review
base-item: Center the thumbnails in an imaginary 256x256 grid (1.85 KB, patch)
2017-02-21 18:54 UTC, Debarshi Ray 		committed Details | Review
utils: Use a fuzz factor to decide whether a thumbnail is too small (2.09 KB, patch)
2017-02-21 18:54 UTC, Debarshi Ray 		committed Details | Review
utils: Don't border the placeholder icons (2.65 KB, patch)
2017-02-21 18:54 UTC, Debarshi Ray 		committed Details | Review
Update to latest libgd (679 bytes, patch)
2017-02-21 18:56 UTC, Debarshi Ray 		committed Details | Review
Update to latest libgd (617 bytes, patch)
2017-03-02 07:41 UTC, Debarshi Ray 		committed Details | Review

Description Allan Day 2017-01-28 11:43:48 UTC 
The new flowbox-based thumbnail grid needs lacks a letterbox around each thumbnail, as shown in the mockups:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/photos/photos-photos-grid.png

Without this, the thumbnail grid looks rather messy.
Comment 1 Debarshi Ray 2017-02-21 18:54:13 UTC 
Created attachment 346383 [details] [review]
utils: Short-circuit larger GdkPixbufs when centering
Comment 2 Debarshi Ray 2017-02-21 18:54:26 UTC 
Created attachment 346384 [details] [review]
base-item: Center the thumbnails in an imaginary 256x256 grid
Comment 3 Debarshi Ray 2017-02-21 18:54:41 UTC 
Created attachment 346385 [details] [review]
utils: Use a fuzz factor to decide whether a thumbnail is too small
Comment 4 Debarshi Ray 2017-02-21 18:54:53 UTC 
Created attachment 346386 [details] [review]
utils: Don't border the placeholder icons
Comment 5 Debarshi Ray 2017-02-21 18:56:43 UTC 
Created attachment 346387 [details] [review]
Update to latest libgd
Comment 6 Debarshi Ray 2017-02-21 18:57:57 UTC 
This needs the following Adwaita patch:
http://jimmac.musichall.cz/stuff/0001-Adwaita-style-flowbox-tiles.patch
Comment 7 Debarshi Ray 2017-03-02 07:41:37 UTC 
Created attachment 347029 [details] [review]
Update to latest libgd