GNOME Bugzilla – Bug 777842
"Set" button should be blue
Last modified: 2017-02-08 16:16:03 UTC
When setting a non-custom shortcut, the "Set" button should be blue. As per: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png
Created attachment 344646 [details] [review] keyboard: make the "Set" button blue Per the available mockups [1], the "Set" button is the suggested action of the dialog and should be blue. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png
Created attachment 344647 [details] [review] keyboard: make the "Set" and "Add" buttons blue Per the available mockups [1], the "Set" and "Add" buttons are the suggested action of the dialog and should be blue. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png
Review of attachment 344647 [details] [review]: That doesn't seem to work. 1. Open keyboard panel 2. Select a "normal" shortcut 3. Press "Backspace" 4. The "Set Shortcut" dialogue's "Set" button isn't blue
Created attachment 344886 [details] [review] keyboard: make the "Set" and "Add" buttons blue Per the available mockups [1], the "Set" and "Add" buttons are the suggested action of the dialog and should be blue. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png
Created attachment 344887 [details] [review] keyboard: ensure the "Add" button is insensitive when adding shortcut After successfully editing a default shortcut (and making sure the "Set" button is sensitive), if the user clicks the '+' row to create a new custom shortcut, the "Add" button is sensitive even with all fields empty. Fix that by ensuring the "Add" button is always sensitive.
Review of attachment 344887 [details] [review]: > keyboard: ensure the "Add" button is insensitive when adding shortcut > Fix that by ensuring the "Add" button is always sensitive. Huh, nope.
Review of attachment 344886 [details] [review]: Looks good.
Created attachment 345113 [details] [review] keyboard: ensure the "Add" button is insensitive when adding shortcut After successfully editing a default shortcut (and making sure the "Set" button is sensitive), if the user clicks the '+' row to create a new custom shortcut, the "Add" button is sensitive even with all fields empty. Fix that by ensuring the "Add" button is always insensitive whenever we add a custom shortcut.
Review of attachment 345113 [details] [review]: Sure.
Thanks for the reviews! Attachment 344886 [details] pushed as c57cadf - keyboard: make the "Set" and "Add" buttons blue Attachment 345113 [details] pushed as e601ae7 - keyboard: ensure the "Add" button is insensitive when adding shortcut