After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777615 - Crash due to desync between two bookmarks popovers
Crash due to desync between two bookmarks popovers
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-22 17:53 UTC by Michael Catanzaro
Modified: 2017-01-22 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add-bookmark-popover: Always create new bookmarks grid when shown (2.15 KB, patch)
2017-01-22 18:20 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2017-01-22 17:53:19 UTC 
* jhbuild run epiphany -p
 * Navigate to example.com
 * Click the add bookmark icon
 * Create a new tag, Misc
 * Open the main bookmarks list popover
 * Switch to Tags view
 * Click on Misc
 * Click on example.com
 * Click on Misc again to cause the tag to be removed from the bookmark
 * Note that in the location entry bookmarks popover, the Misc tag still appears to be selected
 * Click that Misc tag to see what happens. Crash
Comment 1 Michael Catanzaro 2017-01-22 18:13:34 UTC 
(In reply to Michael Catanzaro from comment #0)
> * jhbuild run epiphany -p
>  * Navigate to example.com
>  * Click the add bookmark icon
>  * Create a new tag, Misc
>  * Open the main bookmarks list popover
>  * Switch to Tags view
>  * Click on Misc
>  * Click on example.com
>  * Click on Misc again to cause the tag to be removed from the bookmark

Actually I clicked the X button, deleting the tag from the bookmarks manager.
Comment 2 Michael Catanzaro 2017-01-22 18:20:24 UTC 
The following fix has been pushed:
6784843 add-bookmark-popover: Always create new bookmarks grid when shown
Comment 3 Michael Catanzaro 2017-01-22 18:20:27 UTC 
Created attachment 343990 [details] [review]
add-bookmark-popover: Always create new bookmarks grid when shown

Otherwise it could be stale and lead to crashes.