After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777515 - gtk3-icon-browser doesn't list document-edit-symbolic icon
gtk3-icon-browser doesn't list document-edit-symbolic icon
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-01-20 03:08 UTC by Mohammed Sadiq
Modified: 2017-08-15 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon-browser: add document-edit icon (1.35 KB, patch)
2017-02-16 02:34 UTC, Mohammed Sadiq
none Details | Review

Description Mohammed Sadiq 2017-01-20 03:08:10 UTC
gtk3-icon-browser doesn't list document-edit-symbolic icon
Comment 1 Matthias Clasen 2017-01-24 08:52:49 UTC
What should probably happen here is a way to make it load icons that are not in the predefined list.
Comment 2 Matthias Clasen 2017-02-15 23:52:28 UTC
A patch for this would be welcome
Comment 3 Mohammed Sadiq 2017-02-16 02:34:32 UTC
Created attachment 345911 [details] [review]
icon-browser: add document-edit icon
Comment 4 Daniel Boles 2017-08-06 02:30:56 UTC
Thanks for the report!

(In reply to Matthias Clasen from comment #1)
> What should probably happen here is a way to make it load icons that are not
> in the predefined list.

Matthias has since converted the icon-browser to work this way.

Of course, that didn't include document-edit, since it was not in the source code at that time.

I have added document-edit to the icon.list keyfile here:
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=fd5e929905dfeee4fae07a76e3ea1d0d34c2e1ac

Note that there is no non-symbolic version of this in the Aadwaita icon theme; I don't know if that's intentional.
Comment 5 Daniel Boles 2017-08-06 02:31:49 UTC
(In reply to Daniel Boles from comment #4)
> (In reply to Matthias Clasen from comment #1)
> > What should probably happen here is a way to make it load icons that are not
> > in the predefined list.
> 
> Matthias has since converted the icon-browser to work this way.

Er, no. He converted it to load from a keyfile, which is much nicer, but still requires manual addition of icons... obviously. :)
Comment 6 Matthias Clasen 2017-08-06 12:10:34 UTC
Well, document-edit was missing because it doesn't exist...
Comment 7 Daniel Boles 2017-08-06 12:22:41 UTC
A symbolic variant does, which was requested in the title.

I asked on the original bug for adding that icon whether a non-symbolic variant should exist.

Is your position that if it doesn't, the icon shouldn't be added to the browser so that it can at least be found in the symbolic section? It seems happy enough with that, not giving any error when trying to load or search for the non-symbolic one.
Comment 8 Daniel Boles 2017-08-15 16:30:26 UTC
The titled bug has been fixed, and I've asked for clarification on the thread that added the -symbolic icon, whether they meant to omit a colour version. If anyone wants a colour version in the meantime, they can open a bug for that.