GNOME Bugzilla – Bug 777515
gtk3-icon-browser doesn't list document-edit-symbolic icon
Last modified: 2017-08-15 16:30:26 UTC
What should probably happen here is a way to make it load icons that are not in the predefined list.
A patch for this would be welcome
Created attachment 345911 [details] [review] icon-browser: add document-edit icon
Thanks for the report! (In reply to Matthias Clasen from comment #1) > What should probably happen here is a way to make it load icons that are not > in the predefined list. Matthias has since converted the icon-browser to work this way. Of course, that didn't include document-edit, since it was not in the source code at that time. I have added document-edit to the icon.list keyfile here: https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=fd5e929905dfeee4fae07a76e3ea1d0d34c2e1ac Note that there is no non-symbolic version of this in the Aadwaita icon theme; I don't know if that's intentional.
(In reply to Daniel Boles from comment #4) > (In reply to Matthias Clasen from comment #1) > > What should probably happen here is a way to make it load icons that are not > > in the predefined list. > > Matthias has since converted the icon-browser to work this way. Er, no. He converted it to load from a keyfile, which is much nicer, but still requires manual addition of icons... obviously. :)
Well, document-edit was missing because it doesn't exist...
A symbolic variant does, which was requested in the title. I asked on the original bug for adding that icon whether a non-symbolic variant should exist. Is your position that if it doesn't, the icon shouldn't be added to the browser so that it can at least be found in the symbolic section? It seems happy enough with that, not giving any error when trying to load or search for the non-symbolic one.
The titled bug has been fixed, and I've asked for clarification on the thread that added the -symbolic icon, whether they meant to omit a colour version. If anyone wants a colour version in the meantime, they can open a bug for that.