GNOME Bugzilla – Bug 777482
retro-gobject: Remove unused private code
Last modified: 2017-01-20 09:44:39 UTC
Many types and methods are only internal and not actually used. Removing them until we really need them seems like a sane choice as it avoids to bloat the library and it makes refactoring and maintaining it simpler.
Created attachment 343810 [details] [review] retro-gobject: Sort unsorted commands Sort unused commands in environment_core_command() as they were the only unsorted ones. This makes the code cleaner and more maintainable in the long run.
Created attachment 343811 [details] [review] retro-gobject: Remove unused keyboard callback interface
Created attachment 343812 [details] [review] retro-gobject: Remove unused hardware render interface
Created attachment 343813 [details] [review] retro-gobject: Remove unused audio callback interface
Created attachment 343814 [details] [review] retro-gobject: Remove unused frame time callback interface
Created attachment 343815 [details] [review] retro-gobject: Remove unused sensor interface
Created attachment 343816 [details] [review] retro-gobject: Remove unused camera interface
Created attachment 343817 [details] [review] retro-gobject: Remove unused performance interface
Created attachment 343818 [details] [review] retro-gobject: Remove unused location interface
Created attachment 343819 [details] [review] retro-gobject: Remove unused language
Created attachment 343820 [details] [review] retro-gobject: Remove unused Core.load_game_special() Also remove unused GameType.
Created attachment 343821 [details] [review] retro-gobject: Remove unused Core cheat methods Remove unused Core.cheat_set() and Core.cheat_reset().
Created attachment 343822 [details] [review] retro-gobject: Remove unused Core.region
Created attachment 343823 [details] [review] retro-gobject: Remove unused subsystem
Created attachment 343824 [details] [review] retro-gobject: Remove unused threaded loop
Created attachment 343825 [details] [review] retro-gobject: Remove useless loop interface
Created attachment 343826 [details] [review] retro-gtk: Remove useless display interface
The following fixes have been pushed:
The following fixes have been pushed: 30b19c2 retro-gtk: Remove useless display interface 019138a retro-gobject: Remove useless loop interface 8f094a1 retro-gobject: Remove unused threaded loop f6bdda2 retro-gobject: Remove unused subsystem c8dd5b1 retro-gobject: Remove unused Core.region fb9e61a retro-gobject: Remove unused Core cheat methods b8eac90 retro-gobject: Remove unused Core.load_game_special() a26943f retro-gobject: Remove unused language 2c442c2 retro-gobject: Remove unused location interface 03799e2 retro-gobject: Remove unused performance interface 9e5d794 retro-gobject: Remove unused camera interface 552cab0 retro-gobject: Remove unused sensor interface 38d4f76 retro-gobject: Remove unused frame time callback interface c5ec6ce retro-gobject: Remove unused audio callback interface f5d190e retro-gobject: Remove unused hardware render interface e0133b8 retro-gobject: Remove unused keyboard callback interface a3ede2c retro-gobject: Sort unsorted commands
Created attachment 343870 [details] [review] retro-gtk: Remove useless display interface
Created attachment 343871 [details] [review] retro-gobject: Remove useless loop interface
Created attachment 343872 [details] [review] retro-gobject: Remove unused threaded loop
Created attachment 343873 [details] [review] retro-gobject: Remove unused subsystem
Created attachment 343874 [details] [review] retro-gobject: Remove unused Core.region
Created attachment 343875 [details] [review] retro-gobject: Remove unused Core cheat methods Remove unused Core.cheat_set() and Core.cheat_reset().
Created attachment 343876 [details] [review] retro-gobject: Remove unused Core.load_game_special() Also remove unused GameType.
Created attachment 343877 [details] [review] retro-gobject: Remove unused language
Created attachment 343878 [details] [review] retro-gobject: Remove unused location interface
Created attachment 343879 [details] [review] retro-gobject: Remove unused performance interface
Created attachment 343880 [details] [review] retro-gobject: Remove unused camera interface
Created attachment 343881 [details] [review] retro-gobject: Remove unused sensor interface
Created attachment 343882 [details] [review] retro-gobject: Remove unused frame time callback interface
Created attachment 343883 [details] [review] retro-gobject: Remove unused audio callback interface
Created attachment 343884 [details] [review] retro-gobject: Remove unused hardware render interface
Created attachment 343885 [details] [review] retro-gobject: Remove unused keyboard callback interface
Created attachment 343886 [details] [review] retro-gobject: Sort unsorted commands Sort unused commands in environment_core_command() as they were the only unsorted ones. This makes the code cleaner and more maintainable in the long run.