After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777327 - v4l2allocator: memory type not correctly set in allocator probe
v4l2allocator: memory type not correctly set in allocator probe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.11.1
Other Linux
: Normal normal
: 1.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-16 14:15 UTC by Jean-Christophe Trotin
Modified: 2017-01-16 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2allocator: fix memory type in allocator probe (1.02 KB, patch)
2017-01-16 14:20 UTC, Jean-Christophe Trotin 		committed Details | Review

Description Jean-Christophe Trotin 2017-01-16 14:15:17 UTC 
It seems that the buffer memory type provided to the VIDIOC_CREATE_BUFS ioctl shall be set with the value ("memory") given as input parameter of the
gst_v4l2_allocator_probe() function, instead of being set with the allocator type.

A patch will be attached soon.
Comment 1 Jean-Christophe Trotin 2017-01-16 14:20:36 UTC 
Created attachment 343557 [details] [review]
v4l2allocator: fix memory type in allocator probe
Comment 2 Nicolas Dufresne (ndufresne) 2017-01-16 14:53:31 UTC 
Review of attachment 343557 [details] [review]:

This is correct. A big oops, it worked with UVC since V4L2_BUF_TYPE_VIDEO_CAPTURE == V4L2_MEMORY_MMAP, anything else would fail.
Comment 3 Nicolas Dufresne (ndufresne) 2017-01-16 15:30:28 UTC 
Attachment 343557 [details] pushed as 2b80cd1 - v4l2allocator: fix memory type in allocator probe
Comment 4 Nicolas Dufresne (ndufresne) 2017-01-16 15:57:54 UTC 
Backported to 1.10, will be in 1.10.3, thanks.

commit 1cfe086b1152983dcd9ea8b3190540648020e0e7