After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777133 - Wrong logo when downloading an ISO
Wrong logo when downloading an ISO
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.22.x
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 786679
 
 
Reported: 2017-01-11 13:42 UTC by Debarshi Ray
Modified: 2017-10-12 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Always use media-optical when downloading, not some bogus logo (1.64 KB, patch)
2017-09-11 16:21 UTC, Debarshi Ray 		committed Details | Review
os-database: Specify the OS corresponding to each URI (1.32 KB, patch)
2017-09-11 18:01 UTC, Debarshi Ray 		committed Details | Review
wizard, wizard-source: Try to show a logo while downloading (2.93 KB, patch)
2017-09-11 18:01 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-01-11 13:42:15 UTC 
I saw Shadowman when downloading a Fedora ISO from the suggested URLs in New -> Enter URL. It should have been the blue Fedora logo. Allan said that he got a Ubuntu logo while downloading the Fedora Workstation netinstall ISO.

Sadly, I couldn't reliably reproduce it.
Comment 1 Debarshi Ray 2017-09-11 14:06:02 UTC 
Looking at the code, I am surprised that we even see anything other than "media-optical", which is the generic optical disc icon. The control flow from Wizard::prepare -> Wizard::download_media doesn't set the installer_image at all.
Comment 2 Debarshi Ray 2017-09-11 16:21:42 UTC 
Created attachment 359539 [details] [review]
wizard: Always use media-optical when downloading, not some bogus logo
Comment 3 Debarshi Ray 2017-09-11 18:01:26 UTC 
Created attachment 359551 [details] [review]
os-database: Specify the OS corresponding to each URI
Comment 4 Debarshi Ray 2017-09-11 18:01:39 UTC 
Created attachment 359552 [details] [review]
wizard, wizard-source: Try to show a logo while downloading
Comment 5 Felipe Borges 2017-09-12 10:27:56 UTC 
Attachment 359539 [details] pushed as aa314e0 - wizard: Always use media-optical when downloading, not some bogus logo
Attachment 359551 [details] pushed as a63e080 - os-database: Specify the OS corresponding to each URI
Attachment 359552 [details] pushed as 998e38a - wizard, wizard-source: Try to show a logo while downloading
Comment 6 Felipe Borges 2017-09-12 10:31:45 UTC 
Review of attachment 359539 [details] [review]:

Thanks!
Comment 7 Felipe Borges 2017-09-12 10:31:57 UTC 
Review of attachment 359551 [details] [review]:

sure
Comment 8 Felipe Borges 2017-09-12 10:32:21 UTC 
Review of attachment 359552 [details] [review]:

thanks!