GNOME Bugzilla – Bug 777100
qtmux: Write tapt atom for MOV files if PAR not 1/1
Last modified: 2017-01-12 17:10:19 UTC
See commit message
Created attachment 343253 [details] [review] qtmux: Write tapt atom for MOV files if PAR not 1/1 Needed for QuickTime 7 to properly play files. Also write the clap atom for MOV files always, not only when ProRes is used as a video codec. It's mandatory for MOV.
Comment on attachment 343253 [details] [review] qtmux: Write tapt atom for MOV files if PAR not 1/1 The tapt should be directly in the trak atom, not in the STE
Created attachment 343291 [details] [review] qtmux: Write tapt atom for MOV files if PAR not 1/1 Needed for QuickTime 7 to properly play files. Also write the clap atom for MOV files always, not only when ProRes is used as a video codec. It's mandatory for MOV.
Created attachment 343359 [details] [review] [PATCH] qtmux: Calculate clean aperture size A more generic way to calculate clef and clap values. This is still based on a guess of display aspect ratio (either 16:9 or 4:3), but should be correct for more combinations of size and PAR than the old patch.
Review of attachment 343359 [details] [review]: Generally looks good, just two minor things ::: gst/isomp4/gstqtmux.c @@ +4418,2 @@ + if (qtmux_klass->format == GST_QT_MUX_FORMAT_QT && + width > 640 && width <= 1052 && height >= 480 && height <= 576) { Why only for <HD resolutions? Shouldn't at least clap also be written for HD? @@ +4445,3 @@ + height * par_den); + dar_num = width * par_num / cdiv; + dar_den = height * par_den / cdiv; You calculate width*par_num (and the other one) twice here
'clap' should definitely be ommited for HD, and 'tapt' also doesn't really make sense there. AFAIK, all these things only makes sense for data derived from analogue TV signals in the SD PAL/NTSC world.
Created attachment 343379 [details] [review] [PATCH] qtmux: Calculate clean aperture size
commit fcdba653021dac7acdc017e5811d2b64e7b995cf Author: Georg Lippitsch <glippitsch@toolsonair.com> Date: Wed Jan 11 18:29:05 2017 +0100 qtmux: Calculate clean aperture size Calculate clean aperture dimensions by first guessing display aspect ratio based on pixel aspect ratio and frame size. https://bugzilla.gnome.org/show_bug.cgi?id=777100 commit e12c94065d013986a5f69a14253ee9c439e41301 Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Jan 10 18:19:55 2017 +0200 qtmux: Write tapt atom for MOV files if PAR not 1/1 Needed for QuickTime 7 to properly play files. Also write the clap atom for MOV files always, not only when ProRes is used as a video codec. It's mandatory for MOV. https://bugzilla.gnome.org/show_bug.cgi?id=777100