After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777097 - jpegparse: Chain up to parent class' sink event handler
jpegparse: Chain up to parent class' sink event handler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-01-10 15:22 UTC by Matt Staples
Modified: 2017-01-10 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds call to base class's sink_event (1.00 KB, patch)
2017-01-10 15:32 UTC, Matt Staples 		committed Details | Review

Description Matt Staples 2017-01-10 15:22:00 UTC 
jpegparse overrides gstbaseparse's handling of the GST_EVENT_FLUSH_STOP event without chaining to the base class's implementation. Since the base class sets internal state in response to GST_EVENT_FLUSH_START (especially, priv->flushing=TRUE), this effectively leaves the base class stuck in a flushing state so that no further parsing will occur after an upstream element performs a flush start/stop (e.g., as part of a flushing seek).
Comment 1 Matt Staples 2017-01-10 15:32:25 UTC 
Created attachment 343252 [details] [review]
adds call to base class's sink_event
Comment 2 Sebastian Dröge (slomo) 2017-01-10 15:40:01 UTC 
commit e81e029aa2720b548092f58a933b705fa7cc7a4e
Author: Matt Staples <staples255@gmail.com>
Date:   Tue Jan 10 08:26:04 2017 -0700

    jpegparse: Chain up to parent class' sink event handler
    
    Call base class's sink_event handler after handling GST_EVENT_FLUSH_STOP
    event, so that base class doesn't get stuck in a 'flushing' state
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777097