After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 777053 - tests: Wait for the UI to be drawn completely
tests: Wait for the UI to be drawn completely
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-01-09 18:06 UTC by Iain Lane
Modified: 2017-01-26 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Wait for the UI to be drawn completely (1000 bytes, patch)
2017-01-09 18:06 UTC, Iain Lane 		none Details | Review
Forgot to import 'time' (1.18 KB, patch)
2017-01-09 18:54 UTC, Iain Lane 		committed Details | Review

Description Iain Lane 2017-01-09 18:06:31 UTC 
We're noticing in Debian that there's a race in the testsuite.

I don't know if there's a way to do this properly in dogtail - looked at the docs and couldn't find anything, but maybe I just missed it.
Comment 1 Iain Lane 2017-01-09 18:06:35 UTC 
Created attachment 343177 [details] [review]
tests: Wait for the UI to be drawn completely

We have been seeing tests fail with

  ValueError: Attempting to generate a mouse event at negative coordinates: (-2147483647.5,-2147483647.5)

because the UI isn't drawn when we try to interact with it. This is a
race condition.

Wait until the x or y coordinate is valid before going on with the test.
Comment 2 Iain Lane 2017-01-09 18:54:38 UTC 
Created attachment 343183 [details] [review]
Forgot to import 'time'
Comment 3 Debarshi Ray 2017-01-26 17:06:14 UTC 
Review of attachment 343183 [details] [review]:

Yes, I have seen this problem occasionally. Thanks for digging into it, Laney!