After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776919 - gnome shell crashes with SIGFPE when keyboard repeat interval is set to 0
gnome shell crashes with SIGFPE when keyboard repeat interval is set to 0
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-01-05 21:29 UTC by hanasaki.momoko
Modified: 2017-02-16 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meta-input-settings: Avoid setting key repeat delay or interval to 0 (1.10 KB, patch)
2017-01-09 19:04 UTC, Rui Matos 		committed Details | Review
wayland/keyboard: Avoid a division by zero (1.18 KB, patch)
2017-01-09 19:04 UTC, Rui Matos 		committed Details | Review

Description hanasaki.momoko 2017-01-05 21:29:43 UTC 
Setting the keyboard repeat interval to 0 either via the control panel or with "gsettings set org.gnome.desktop.peripherals.keyboard repeat-interval 0" instantly crashes the gnome-shell process. Graphical login attempts are impossible until you use gsettings to change the value to something > 0.
Comment 1 Rui Matos 2017-01-09 19:04:03 UTC 
Created attachment 343189 [details] [review]
meta-input-settings: Avoid setting key repeat delay or interval to 0

Since doing so causes either errors or misbehavior.
Comment 2 Rui Matos 2017-01-09 19:04:10 UTC 
Created attachment 343190 [details] [review]
wayland/keyboard: Avoid a division by zero

We don't further sanitize the values since the protocol allows for
everything as long as it's non-negative.
Comment 3 Florian Müllner 2017-02-16 14:34:19 UTC 
Review of attachment 343190 [details] [review]:

OK
Comment 4 Florian Müllner 2017-02-16 14:34:29 UTC 
Review of attachment 343189 [details] [review]:

LGTM
Comment 5 Rui Matos 2017-02-16 15:53:20 UTC 
Attachment 343189 [details] pushed as 966725f - meta-input-settings: Avoid setting key repeat delay or interval to 0
Attachment 343190 [details] pushed as 36ee6f6 - wayland/keyboard: Avoid a division by zero