GNOME Bugzilla – Bug 776900
decklinkvideosrc: Do not append a zero timecode if none is found on the source
Last modified: 2017-01-09 16:38:25 UTC
If the source doesn't give us timecode information, do not append a zero timecode to the frames.
Created attachment 342954 [details] [review] 0001-decklinkvideosrc-Do-not-append-a-zero-timecode-if-no.patch
Review of attachment 342954 [details] [review]: ::: sys/decklink/gstdecklink.cpp @@ +853,1 @@ } This code here seems to leak the IDeckLinkTimecode. You need to call ::Release() on it, like on the frames/packets (done inside got_video_frame / got_audio_packet at some point). ::: sys/decklink/gstdecklink.h @@ +211,2 @@ /* Set by the video source */ + void (*got_video_frame) (GstElement *videosrc, IDeckLinkVideoInputFrame * frame, GstDecklinkModeEnum mode, GstClockTime capture_time, GstClockTime stream_time, GstClockTime stream_duration, guint hours, guint minutes, guint seconds, guint frames, BMDTimecodeFlags bflags, gboolean no_signal, gboolean have_timecode); Generally all looks good, but it would seem better to reduce the amount of parameters here a lot by just passing the IDeckLinkTimeCode * here. It being NULL would mean no timecode then and the consumer can make use of that
Created attachment 342976 [details] [review] 0001-decklinkvideosrc-Do-not-append-a-zero-timecode-if-no.patch Thanks for the comments. Attaching the updated version.
commit 3cb43f35b837111a376924503a73dfda425731e0 Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Thu Jan 5 15:41:06 2017 +0200 decklinkvideosrc: Do not append a zero timecode if none is found on the source If the source doesn't give us timecode information, do not append a zero timecode to the frames. https://bugzilla.gnome.org/show_bug.cgi?id=776900
Merging into 1.10 later