After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776810 - gst-uninstalled doesn't set PKG_CONFIG_PATH
gst-uninstalled doesn't set PKG_CONFIG_PATH
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
unspecified
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 776867
Blocks:
 
 
Reported: 2017-01-03 12:40 UTC by Guillaume Desmottes
Modified: 2017-01-05 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: meson: generate pkg-config -uninstalled pc files (5.64 KB, patch)
2017-01-04 13:23 UTC, Guillaume Desmottes
committed Details | Review
gst-uninstalled: set PKG_CONFIG_PATH (1.65 KB, patch)
2017-01-04 13:23 UTC, Guillaume Desmottes
none Details | Review
gst-uninstalled: set PKG_CONFIG_PATH (1.64 KB, patch)
2017-01-04 13:37 UTC, Guillaume Desmottes
committed Details | Review
base: meson: generate pkg-config -uninstalled pc files (11.87 KB, patch)
2017-01-04 14:21 UTC, Guillaume Desmottes
committed Details | Review
editing-service: meson: generate pkg-config -uninstalled pc files (2.75 KB, patch)
2017-01-04 15:00 UTC, Guillaume Desmottes
committed Details | Review
rtsp-server: meson: generate pkg-config -uninstalled pc files (2.86 KB, patch)
2017-01-04 15:26 UTC, Guillaume Desmottes
committed Details | Review
bad: meson: generate pkg-config -uninstalled pc files (10.63 KB, patch)
2017-01-04 16:11 UTC, Guillaume Desmottes
committed Details | Review
validate: meson: generate pkg-config -uninstalled pc files (2.83 KB, patch)
2017-01-04 16:42 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2017-01-03 12:40:43 UTC
The new gst-uninstalled doesn't set the PKG_CONFIG_PATH env variable as the old one does. This makes hard for external app to link to the gstreamer core built using meson.

I tried adding this by using the output of 'mesonintrospect --installed' which is pretty straightforward. But that's doesn't work because the pc files installed in, say, build/subprojects/gstreamer/pkgconfig/ have /usr/local as prefix, not the build/ directory.

So I guess we have two options here:
a) pass a custom prefix when building with gst-build so the pc files in build/ have the right paths.
b) use the *-uninstalled.pc from the source directories, but we don't have any clean way of discovering those so they'll have to be hardcoded in gst-uninstalled.py
Comment 1 Guillaume Desmottes 2017-01-04 13:23:25 UTC
Created attachment 342833 [details] [review]
core: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.
Comment 2 Guillaume Desmottes 2017-01-04 13:23:43 UTC
Created attachment 342834 [details] [review]
gst-uninstalled: set PKG_CONFIG_PATH

Lookg for -uninstalled pc files and update PKG_CONFIG_PATH with the
directories containing those.

This feature is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.

Fix a regression from the old gst-uninstalled tool.
Comment 3 Thibault Saunier 2017-01-04 13:26:01 UTC
Review of attachment 342833 [details] [review]:

lgtm
Comment 4 Thibault Saunier 2017-01-04 13:26:46 UTC
Review of attachment 342834 [details] [review]:

lgtm
Comment 5 Guillaume Desmottes 2017-01-04 13:37:48 UTC
Created attachment 342837 [details] [review]
gst-uninstalled: set PKG_CONFIG_PATH

Look for -uninstalled pc files and update PKG_CONFIG_PATH with the
directories containing those.

This feature is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.

Fix a regression from the old gst-uninstalled tool.
Comment 6 Guillaume Desmottes 2017-01-04 14:21:41 UTC
Created attachment 342841 [details] [review]
base: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.
Comment 7 Guillaume Desmottes 2017-01-04 15:00:33 UTC
Created attachment 342849 [details] [review]
editing-service: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.
Comment 8 Guillaume Desmottes 2017-01-04 15:26:14 UTC
Created attachment 342860 [details] [review]
rtsp-server: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.
Comment 9 Guillaume Desmottes 2017-01-04 16:11:14 UTC
Created attachment 342868 [details] [review]
bad: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.

While doing so, fix some -uninstalled pc files which were using a
suspicious 'pcfiledir' which was never replaced or defined.
Comment 10 Guillaume Desmottes 2017-01-04 16:42:39 UTC
Created attachment 342872 [details] [review]
validate: meson: generate pkg-config -uninstalled pc files

Generating those files is useful for users building the GStreamer stack
using meson and having to link it to another project which is still
using the autotools.

Fixed the -uninstalled pc file libdir path while I was on it.
Comment 11 Thibault Saunier 2017-01-05 13:00:11 UTC
Attachment 342837 [details] pushed as 0d2f4e1 - gst-uninstalled: set PKG_CONFIG_PATH
Comment 12 Thibault Saunier 2017-01-05 13:03:22 UTC
commit 4bb8e5c191335805fb6a3a7a0d53608f6c281dc3
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 12:10:45 2017 +0100

    meson: generate pkg-config -uninstalled pc files


gst-plugins-base: master

commit b01f8891f41f0e9ae94837bf73208cb1b16ff913
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 14:56:36 2017 +0100

    meson: generate pkg-config -uninstalled pc files


gst-plugins-bad: master

commit e92837b6e40b5ed706239a2a1814ff1c1f0d2ff5
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 16:51:10 2017 +0100

    meson: generate pkg-config -uninstalled pc files


gst-devtools/validate: master

commit 7c613ec3476dc0a5b0411dc76f9704eb942cb22b
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 17:40:59 2017 +0100

    meson: generate pkg-config -uninstalled pc files


gst-editing-services: master

commit e0fba540f22c0c5ae10eeab5e5a7d47759f7a0f8
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 15:55:36 2017 +0100

    meson: generate pkg-config -uninstalled pc files

gst-rtsp-server: master

commit e6c6bf96ce7d3240b5343c52ff6218a323258781
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Jan 4 16:20:54 2017 +0100

    meson: generate pkg-config -uninstalled pc files