GNOME Bugzilla – Bug 776671
Replace the GraphUpdated handler with TrackerNotifier
Last modified: 2018-01-23 10:09:50 UTC
I am trying to build this application from source in my git cloned directory of the master branch and I have come across this make error: photos-tracker-change-monitor.c:95:1: error: packed attribute is unnecessary for ‘_TrackerResourcesEvent’ [-Werror=packed] } __attribute__ ((packed)); Full make is located here: http://pastebin.com/EvAHxa4W
Here is an archived version of the link in case the original becomes dead: http://web.archive.org/web/20170101053903/http://pastebin.com/EvAHxa4W
Short term solution is to use --disable-Werror with autogen.sh or configure when building from git. When building from a released tarball, warnings are not treated as fatal, so those should be fine. Today we can remove most of the code in src/photos-tracker-change-monitor.[ch] by using TrackerNotifier. See bug 773028. One could argue that we can just drop the __attribute__, but I haven't done that so far because it is not clear to me that it is really not needed across all possible architectures.
I forgot to ask. Would you be interested in porting the code to use TrackerNotifier?
(In reply to Debarshi Ray from comment #3) > I forgot to ask. Would you be interested in porting the code to use > TrackerNotifier? I can try but I wouldn't expect reliable results if I were you, let alone reaching dead line. I'm very new to this whole bug process and I'm still learning. But for the sake of knowledge, what would porting code of this calibre entail?
(In reply to Scott Cohen from comment #4) > (In reply to Debarshi Ray from comment #3) > > I forgot to ask. Would you be interested in porting the code to use > > TrackerNotifier? > > I can try but I wouldn't expect reliable results if I were you, let alone > reaching dead line. I'm very new to this whole bug process and I'm still > learning. That's ok. I tagged this bug as 'newcomer' because it is ideal for new contributors. > But for the sake of knowledge, what would porting code of this > calibre entail? First, you need to know some C because that's what the code is written in. Second, you will need to build and install tracker from git master. TrackerNotifier was added in 1.11.0. You can look at other instances where the GraphUpdated handler was replaced with TrackerNotifier. There is one example in tracker itself. See src/libtracker-miner/tracker-decorator.c, run git log on it and you will find it. The TrackerNotifier API lives in src/libtracker-sparql/tracker-notifier.[ch]. You can look at it for documentation. In case you built tracker to generate the documentation, they will also show up in devhelp. If you need help, you can find me in #photos and #tracker on GIMPNet, or send email.
Reopening. Did you close it by mistake?
(In reply to Debarshi Ray from comment #6) > Reopening. Did you close it by mistake? It seemed like there was a solution to the bug. Are workarounds not considered solutions?
(In reply to Scott Cohen from comment #7) > (In reply to Debarshi Ray from comment #6) > > Reopening. Did you close it by mistake? > > It seemed like there was a solution to the bug. Are workarounds not > considered solutions? Well, since we already started discussing, I re-titled it to cover the port to TrackerNotifier. So, let's keep it open for that.
Here's the reference documentation on TrackerNotifier: https://developer.gnome.org/libtracker-sparql/stable/TrackerNotifier.html
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/59.