After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776659 - CellRenderer: Remove render() vfunc
CellRenderer: Remove render() vfunc
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
3.89.x
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2016-12-31 19:16 UTC by Daniel Boles
Modified: 2017-01-02 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Regenerate GDK and GTK+ docs and defs (131.70 KB, patch)
2016-12-31 19:58 UTC, Daniel Boles
rejected Details | Review

Description Daniel Boles 2016-12-31 19:16:49 UTC
To match GTK+. Currently, cellrenderer.cc just throws a pile of errors.

https://git.gnome.org/browse/gtk+/commit/?id=a36e5ceea74fecb7b8f5f196e592a4b633ed6eb3
Comment 1 Daniel Boles 2016-12-31 19:58:50 UTC
Created attachment 342672 [details] [review]
Regenerate GDK and GTK+ docs and defs

With some minor detective work, I think I figured it how you do this:

> cd tools/gen_scripts
> export JHBUILD_SOURCES=~/jhbuild/checkout/gnome; for f in *.sh; do ./$f; done

This fixes the problems with CellRenderer, and takes me to a new one:

>   GEN    /home/daniel/jhbuild/checkout/gnome/gtkmm/gtk/gtkmm{entrycompletion.cc,entrycompletion.h,private/entrycompletion_p.h}
> No conversion from const Glib::Error& to GError* defined (line: 82, parameter name: error)
> m4 failed with exit code 1.  Aborting...
> Makefile:798: recipe for target '/home/daniel/jhbuild/checkout/gnome/gtkmm/gtk/src/.stamps/cssprovider.stamp' failed

After swearing at make -j8 for making it hard to figure out where the problem was, I traced it to cssprovider.h
Comment 2 Kjell Ahlstedt 2017-01-02 12:22:53 UTC
Review of attachment 342672 [details] [review]:

What's this? Have you used a mixture of files from the master branch and the
gtkmm-3-22 branch? Much of what the patch adds to gtk_signals.defs is info on
classes that have been removed from the master branch, such as GtkAction and
GtkUIManager.

I have pushed a different patch that removes some render functions, because the
corresponding gtk+ functions have been removed.
https://git.gnome.org/browse/gtkmm/commit/?id=7535c82fea6f84fb598d3a9ca798b5287da8bcf5
Comment 3 Daniel Boles 2017-01-02 14:39:00 UTC
git must not be removing obsolete files when I switch branches or something as I've seen a few oddities like this. Should've checked the result in more depth. Thanks.
Comment 4 Kjell Ahlstedt 2017-01-02 17:39:19 UTC
When you switch branches, git deletes obsolete files that are stored in git's
repository. But it does not care about generated files.
If you expect to switch repeatedly back and forth between two branches, it can
be better to keep your local copies of those two branches in different
directories.