After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776612 - adaptivedemux: Handle SEEK event only once
adaptivedemux: Handle SEEK event only once
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-30 09:51 UTC by Seungha Yang
Modified: 2017-02-02 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adaptivedemux: Handle SEEK event only once (2.82 KB, patch)
2016-12-30 09:53 UTC, Seungha Yang 		none Details | Review
adaptivedemux: Handle SEEK event only once (1.26 KB, patch)
2017-01-01 05:15 UTC, Seungha Yang 		none Details | Review
adaptivedemux: Handle SEEK event only once (1.30 KB, patch)
2017-01-01 05:17 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2016-12-30 09:51:24 UTC 
send_event() of parent class (i.e., GstBinClass) iterates srcpads
to send SEEK event. And performing it per srcpad is inefficient.
Note that, Decodebin2 sends SEEK event directly to adaptivedemux
by using gst_element_send_event()
Comment 1 Seungha Yang 2016-12-30 09:53:30 UTC 
Created attachment 342610 [details] [review]
adaptivedemux: Handle SEEK event only once
Comment 2 Sebastian Dröge (slomo) 2016-12-30 10:39:03 UTC 
Comment on attachment 342610 [details] [review]
adaptivedemux: Handle SEEK event only once

Isn't this exactly the same as the GstBin implementation? Iterating over all srcpads and sending the event.

You probably instead want to handle seek events directly in send_event(). But to de-duplicate seek events, do that based on the event's sequence number.
Comment 3 Seungha Yang 2017-01-01 05:14:21 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 342610 [details] [review] [review]
> adaptivedemux: Handle SEEK event only once
> 
> Isn't this exactly the same as the GstBin implementation? Iterating over all
> srcpads and sending the event.

Iterator was used only to finding srcpad, and iteration will be stopped when finding srcpad.
Anyway, checking seqnum seem to be more pretty :)
Comment 4 Seungha Yang 2017-01-01 05:15:53 UTC 
Created attachment 342682 [details] [review]
adaptivedemux: Handle SEEK event only once
Comment 5 Seungha Yang 2017-01-01 05:17:45 UTC 
Created attachment 342683 [details] [review]
adaptivedemux: Handle SEEK event only once
Comment 6 Sebastian Dröge (slomo) 2017-01-31 11:26:25 UTC 
Attachment 342683 [details] pushed as 780c57d - adaptivedemux: Handle SEEK event only once