After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776586 - License headers cleanup
License headers cleanup
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.51.x
Other All
: Normal enhancement
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 776504
 
 
Reported: 2016-12-29 17:44 UTC by Sébastien Wilmet
Modified: 2017-01-04 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
License headers: "The GLib Library" -> "This library" (1.64 KB, patch)
2016-12-29 17:49 UTC, Sébastien Wilmet 		committed Details | Review
License headers: "GLib" -> "This library" (20.85 KB, patch)
2016-12-29 17:49 UTC, Sébastien Wilmet 		committed Details | Review
License headers: "the Gnome Library" -> "this library" (25.17 KB, patch)
2016-12-29 17:49 UTC, Sébastien Wilmet 		committed Details | Review
License headers: replace old FSF address by a link to gnu.org (4.18 KB, patch)
2016-12-29 17:49 UTC, Sébastien Wilmet 		committed Details | Review
License headers: replace current FSF address by a link to gnu.org (8.05 KB, patch)
2016-12-29 17:49 UTC, Sébastien Wilmet 		committed Details | Review

Description Sébastien Wilmet 2016-12-29 17:44:59 UTC 
Some cleanup before fixing bug #776504 (upgrade to the LGPLv2.1).

See the attached patches.
Comment 1 Sébastien Wilmet 2016-12-29 17:49:12 UTC 
Created attachment 342582 [details] [review]
License headers: "The GLib Library" -> "This library"

Harmonize a little the license headers. In most of the license headers
in GLib, it is "This library".

It is also what is explained at:
https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html#SEC4
"How to Apply These Terms to Your New Libraries"
Comment 2 Sébastien Wilmet 2016-12-29 17:49:17 UTC 
Created attachment 342583 [details] [review]
License headers: "GLib" -> "This library"

Harmonize a little the license headers. In most of the license headers
in GLib, it is "This library".

It is also what is explained at:
https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html#SEC4
"How to Apply These Terms to Your New Libraries"
Comment 3 Sébastien Wilmet 2016-12-29 17:49:24 UTC 
Created attachment 342584 [details] [review]
License headers: "the Gnome Library" -> "this library"

Harmonize a little the license headers. In most of the license headers
in GLib, it is "this library".

It is also what is explained at:
https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html#SEC4
"How to Apply These Terms to Your New Libraries"
Comment 4 Sébastien Wilmet 2016-12-29 17:49:37 UTC 
Created attachment 342585 [details] [review]
License headers: replace old FSF address by a link to gnu.org
Comment 5 Sébastien Wilmet 2016-12-29 17:49:42 UTC 
Created attachment 342586 [details] [review]
License headers: replace current FSF address by a link to gnu.org

Even if the address is correct, it's far more convenient to have a link
to a website.
Comment 6 Emmanuele Bassi (:ebassi) 2017-01-04 17:10:03 UTC 
Review of attachment 342582 [details] [review]:

ACK.
Comment 7 Emmanuele Bassi (:ebassi) 2017-01-04 17:10:50 UTC 
Review of attachment 342583 [details] [review]:

ACK.
Comment 8 Emmanuele Bassi (:ebassi) 2017-01-04 17:11:23 UTC 
Review of attachment 342584 [details] [review]:

ACK.
Comment 9 Emmanuele Bassi (:ebassi) 2017-01-04 17:11:43 UTC 
Review of attachment 342585 [details] [review]:

ACK.
Comment 10 Emmanuele Bassi (:ebassi) 2017-01-04 17:12:07 UTC 
Review of attachment 342586 [details] [review]:

ACK.
Comment 11 Sébastien Wilmet 2017-01-04 18:15:12 UTC 
Thanks for the review. All commits pushed on master.
Comment 12 Sébastien Wilmet 2017-01-04 18:16:08 UTC 
Attachment 342582 [details] pushed as e603035 - License headers: "The GLib Library" -> "This library"
Attachment 342583 [details] pushed as 8edcf67 - License headers: "GLib" -> "This library"
Attachment 342584 [details] pushed as f605905 - License headers: "the Gnome Library" -> "this library"
Attachment 342585 [details] pushed as 46c0c5c - License headers: replace old FSF address by a link to gnu.org
Attachment 342586 [details] pushed as 6231b1a - License headers: replace current FSF address by a link to gnu.org