After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776582 - h264parse: keyframes marked as delta unit
h264parse: keyframes marked as delta unit
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-29 16:09 UTC by Nicola
Modified: 2018-11-03 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file that show the issue (1.86 MB, application/octet-stream)
2016-12-29 16:09 UTC, Nicola 		  Details
proposed fix (1.13 KB, patch)
2016-12-30 10:07 UTC, Nicola 		none Details | Review
alternative patch (1.59 KB, patch)
2016-12-30 10:59 UTC, Nicola 		none Details | Review

Description Nicola 2016-12-29 16:09:32 UTC 
Created attachment 342575 [details]
file that show the issue

Please try this pipeline and observe the output

gst-launch-1.0 -v filesrc location= test.gdp ! gdpdepay  ! fakesink silent=false

you can see that all keyframes are correctly marked as such, for example:

42672 bytes, dts: none, pts: 0:00:01.667941354, duration: none, offset: -1, offset_end: -1, flags: 00000000 

42667 bytes, dts: none, pts: 0:00:03.267941354, duration: none, offset: -1, offset_end: -1, flags: 00000000 

now try to add h264parse:

gst-launch-1.0 -v filesrc location= test.gdp ! gdpdepay ! h264parse ! video/x-h264,stream-format=avc,alignment=au ! fakesink silent=false 

42672 bytes, dts: 0:00:01.401274664, pts: 0:00:01.667941354, duration: 0:00:00.033333333, offset: 91068, offset_end: -1, flags: 00002000 delta-unit

42667 bytes, dts: 0:00:02.734607984, pts: 0:00:03.267941354, duration: 0:00:00.033333333, offset: 182136, offset_end: -1, flags: 00002000 delta-unit

keyframes are now marked as delta-unit!
Comment 1 Nicola 2016-12-30 10:07:03 UTC 
Created attachment 342611 [details] [review]
proposed fix

with the test file sps parsing fails and a fallback sps is used but since the parser state is not updated we have the reported issue. I think that if sps parsing fails parser state and header should be updated anyway since an sps is received
Comment 2 Nicola 2016-12-30 10:30:50 UTC 
probably the same should be done few lines below when pps parsing fails and we use fallback pps but I don't have a file/stream that trigger this error
Comment 3 Nicola 2016-12-30 10:59:08 UTC 
Created attachment 342618 [details] [review]
alternative patch

this method works too, we don't store the sps when parsing fails but we do all the other things
Comment 4 Nicola 2017-01-23 15:43:01 UTC 
no opinions? I'm using the first patch since some weeks with no issues
Comment 5 GStreamer system administrator 2018-11-03 14:02:44 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/503.