After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776543 - Trigger pad (o)led changes on mode switches
Trigger pad (o)led changes on mode switches
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-28 12:08 UTC by Carlos Garnacho
Modified: 2017-02-10 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Add MetaDisplay::pad-mode-switch signal (1.78 KB, patch)
2016-12-28 12:08 UTC, Carlos Garnacho 		committed Details | Review
windowManager: Use g-s-d wacom dbus helpers to update pad leds/oleds (3.16 KB, patch)
2016-12-28 12:09 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2016-12-28 12:08:10 UTC 
I'm attaching some patches that let mutter/gnome-shell rely on g-s-d to update pad leds and oleds on mode switches. These patches are on top of those in bug #771098, since both involve notification around pad mode switches.
Comment 1 Carlos Garnacho 2016-12-28 12:08:47 UTC 
Created attachment 342533 [details] [review]
core: Add MetaDisplay::pad-mode-switch signal

This signal provides the necessary information to let gnome-shell trigger
updates of pad leds/oleds whenever a pad group switches mode, and the
actions associated to buttons do too.
Comment 2 Carlos Garnacho 2016-12-28 12:09:07 UTC 
Created attachment 342534 [details] [review]
windowManager: Use g-s-d wacom dbus helpers to update pad leds/oleds

This keeps feedback on the device itself in sync with the overall pad
state, a feature we had previously through g-s-d.
Comment 3 Carlos Garnacho 2017-02-10 22:54:19 UTC 
Comment on attachment 342533 [details] [review]
core: Add MetaDisplay::pad-mode-switch signal

Attachment 342533 [details] pushed as 9950b4d - core: Add MetaDisplay::pad-mode-switch signal
Comment 4 Carlos Garnacho 2017-02-10 23:07:54 UTC 
Pushed in sync with g-s-d's bug #778472

Attachment 342534 [details] pushed as 0008ef7 - windowManager: Use g-s-d wacom dbus helpers to update pad leds/oleds