After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776499 - error type not found - causes display issues
error type not found - causes display issues
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
3.16.x
Other Mac OS
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-26 14:47 UTC by Adrian Bridgett
Modified: 2016-12-30 01:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adrian Bridgett 2016-12-26 14:47:17 UTC
If there is an error (comparing directories which had a dangling symlink) then diffmap.py tries to lookup a fill_colors and line_colors for 'error'.  The (odd) effect of this is that the file display has two lines for the file in question which then causes the entire meld app to be rerendered at approx 2x resolution (HiDPI display).

Traceback (most recent call last):
  File /usr/local/lib/python2.7/site-packages/meld/diffmap.py, line 146, in do_draw
    cache_ctx.set_source_rgba(*self.fill_colors[tag])
KeyError: 'error'

(same again at line 151).   Adding an 'error' type in fixes this.
Comment 1 Kai Willadsen 2016-12-30 01:25:07 UTC
I've just pushed the fix you describe to the 3.16 branch and master. Thanks for your bug report!