GNOME Bugzilla – Bug 776493
Add new cities from Kazakhstan.
Last modified: 2021-06-09 21:07:35 UTC
Created attachment 342476 [details] [review] Fixes for Kazakhstan cities Hi, I have corrected spellings for several cities and added new cities. Thanks,
Hi, Any news on this request? is it too late for 3.24?
Created attachment 348376 [details] [review] Update for Kazakhstan cities Please review this current patch, it replaces the previous one and also adds missing tz-hint for Atyrau city. Thanks,
Dear maintainers, Please review this addition, are we late for GNOME 3-26? Thanks,
Review of attachment 348376 [details] [review]: It would be great if you could split up this patch in multiple ones ("git add -p" would allow you do commit only parts of your changes each time). I'm guessing 3 separate patches: - explain the name changes - make all the additions in one patch - explain why you're replacing a particular city with another I'm guessing your patch also fixes bug 626770, so all the cities in the list have the correct timezones? ::: data/Locations.xml.in @@ +4932,1 @@ <code>UATT</code> This airport doesn't provide weather data anymore. @@ -4976,2 @@ --> - <_name>Qaraghandy</_name> Why do you change Qaraghandy to Oskemen? @@ -4988,2 @@ --> - <_name>Qostanay</_name> Same here for Qostanay and Petropavl @@ +5047,3 @@ + <!-- A city in Kazakhstan --> + <_name>Pavlodar</_name> + <coordinates>52.264656, 76.970022</coordinates> Those coordinates are invalid, there shouldn't be a "," @@ -4999,3 @@ - The local name in Russian is "Kyzylorda". - --> - <_name>Qyzylorda</_name> And Qyzylorda to Pavlodar @@ +5050,3 @@ <location> + <name>Pavlodar Airport</name> + <code>UASP</code> This airport doesn't provide weather data either.
It might make sense to also split up cities in states, so that we can assign each state the preferred timezone, without needing to assign it to each city.
Created attachment 365486 [details] [review] locations: Update cities of Kazakhstan NEEDS WORK
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgweather/-/issues/134.