After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776277 - TypeError: could not get a reference to type class in generate-setting-docs.py
TypeError: could not get a reference to type class in generate-setting-docs.py
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Thomas Haller
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-12-19 14:39 UTC by Michael Catanzaro
Modified: 2017-01-25 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build log (66.54 KB, text/plain)
2016-12-19 15:28 UTC, Michael Catanzaro
Details
Patch (1.22 KB, text/plain)
2017-01-18 18:58 UTC, Lubomir Rintel
Details

Description Michael Catanzaro 2016-12-19 14:39:13 UTC
I'm not sure what changed here, since I tested this just a couple days ago and it seemed to be working fine, but NetworkManager is broken in JHBuild again. The error is going to be pasted in the next comment due to bug #776275.

It happens with both python2 and python3.
Comment 1 Michael Catanzaro 2016-12-19 14:39:22 UTC
/home/mcatanzaro/src/jhbuild/checkout/NetworkManager/libnm/generate-setting-docs.py:191: Warning: cannot retrieve class for invalid (unclassed) type 'void'
  setting = new_func()
Traceback (most recent call last):
  • File "/home/mcatanzaro/src/jhbuild/checkout/NetworkManager/libnm/generate-setting-docs.py", line 191 in <module>
    setting = new_func()
TypeError: could not get a reference to type class

Comment 2 Thomas Haller 2016-12-19 15:06:51 UTC
Hi,

Can you share a log to the build?
What are the full configure options to reproduce?
What's the git commit ID of the failing build?

Could be related to bug 776178
Comment 3 Michael Catanzaro 2016-12-19 15:28:49 UTC
Created attachment 342221 [details]
build log

Build log (including all configure options set by JHBuild). Commit is d136f0fedc37b23c39955da7442cfdcd0db75114 "libnm/docs: clarify "ipvx.dns-priority" setting in documentation"
Comment 4 Michael Catanzaro 2016-12-19 15:30:50 UTC
I'll drop that unrecognized --disable-wimax flag from JHBuild now.
Comment 5 Thomas Haller 2016-12-19 18:17:39 UTC
I cannot reproduce this build failure :(
Comment 6 Michael Catanzaro 2016-12-20 16:52:34 UTC
I can reproduce it always on a clean build, but I don't understand the python nor the gobject-introspection involved. :(
Comment 7 Thomas Haller 2017-01-10 11:22:46 UTC
I am unable to reproduce this with Ubuntu16.10, following the jhbuild instructions from https://wiki.gnome.org/Newcomers/BuildGnome
(and ensuring to actually build upstream master of NetworkManager).
Comment 8 Michael Catanzaro 2017-01-10 20:18:37 UTC
Thomas, thanks for testing this out in JHBuild.

I spun up a new Ubuntu VM today and found that, indeed, the build works fine. Really sorry for sending you on this wild goose chase with an Ubuntu VM, I'm sure that took a couple hours. :(

Then I tried to test with JHBuild on Fedora. I've made sure I'm using a completely clean build directory (rm -rf ~/.cache/jhbuild/build/NetworkManager) and source directory (git clean -xfd). I can reproduce it reliably here. So for whatever reason, the bug occurs on Fedora and not Ubuntu.

Next, I cleared the source directory with git clean -xfd again and tried a build without using JHBuild at all (on Fedora), starting with './autogen.sh --disable-json-validation'. This worked fine.

Next, I tried a build outside JHBuild with configure options similar to those set by JHBuild:

./autogen.sh PYTHON=python3 --disable-json-validation --disable-more-warnings --with-crypto=gnutls

And that went fine too.

So the issue is somehow specific to JHBuild on Fedora. (Which is unfortunately what I use for making GNOME releases....)

(In reply to Michael Catanzaro from comment #0)
> I'm not sure what changed here, since I tested this just a couple days ago
> and it seemed to be working fine, but NetworkManager is broken in JHBuild
> again.

I think what changed was I had been working in an Ubuntu VM to make sure it was fine there, then switched back to Fedora and found it was broken, and forgot I had switched operating systems.
Comment 9 Thomas Haller 2017-01-11 13:12:43 UTC
I am also unable to reproduce on F25 (both my machine and a newly installed VM).

Maybe you need to run `jhbuild sysdeps --install`?


Well... actually, yesterday when testing with Ubuntu1610 I saw the failure once, but couldn't get a grip on it. Afterwards I was unable to reproduce it even by purging the entire home directory.
Comment 10 Michael Catanzaro 2017-01-11 22:40:20 UTC
(In reply to Thomas Haller from comment #9)
> I am also unable to reproduce on F25 (both my machine and a newly installed
> VM).

:/

> Maybe you need to run `jhbuild sysdeps --install`?

'jhbuild build NetworkManager' will fail if you are missing sysdeps required by NetworkManager or its dependencies. But sometimes a module is missing a dependency. At any rate, I have all sysdeps installed for all of GNOME.

> Well... actually, yesterday when testing with Ubuntu1610 I saw the failure
> once, but couldn't get a grip on it. Afterwards I was unable to reproduce it
> even by purging the entire home directory.

Shame....
Comment 11 Andreas Nilsson 2017-01-12 18:10:45 UTC
I ran into this on F25 as well
http://pastebin.com/BFgxueJs
Comment 12 Lubomir Rintel 2017-01-18 18:58:42 UTC
Created attachment 343740 [details]
Patch

Seems like a gobject-introspection or glib bug to me.

Here's a patch that works around it.
Comment 13 Michael Catanzaro 2017-01-25 17:47:54 UTC
(In reply to Lubomir Rintel from comment #12)
> Created attachment 343740 [details]
> Patch
> 
> Seems like a gobject-introspection or glib bug to me.
> 
> Here's a patch that works around it.

Could this be committed?