GNOME Bugzilla – Bug 776259
Port from gnome-common to autoconf-archive
Last modified: 2017-07-02 01:19:44 UTC
This drops totem-pl-parser’s dependency on gnome-common because it’s deprecated. The patch set bumps our GLib dependency to 2.36.0 (from 2.31.0), and replaces our gnome-common dependency with one on autoconf-archive or (in jhbuild) m4-common. m4-common is a caching subset of autoconf-archive for use within GNOME.
Created attachment 342198 [details] [review] build: Update autogen.sh to latest GNOME recommendation https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342199 [details] [review] build: Add AX_IS_RELEASE macro This is useless by itself but is needed to key various new macros (which will be added shortly) about whether they are running for a release or debug build. https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342200 [details] [review] build: Port from GNOME_CODE_COVERAGE to AX_CODE_COVERAGE This adds a dependency on autoconf-archive (or the m4-common subset of it in GNOME). Functionally, the two macros are the same, but the latter is in autoconf-archive so is more generally useful. https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342201 [details] [review] build: Port from GNOME_DEBUG_CHECK to AX_CHECK_ENABLE_DEBUG The former is deprecated and replaced by the latter. This enables debug by default for non-release builds. https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342202 [details] [review] build: Drop use of GNOME_MAINTAINER_MODE_DEFINES It is deprecated and doesn’t currently do anything useful. https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342203 [details] [review] build: Port from GNOME_COMPILE_WARNINGS to AS_COMPILER_FLAGS The latter gives a more standardised set of default warnings, and standardised control over -Werror using --disable-Werror (which can be enabled by default for non-release builds, for example; and disabled by default for buildbots). https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 342204 [details] [review] fixup! build: Port from GNOME_DEBUG_CHECK to AX_CHECK_ENABLE_DEBUG
Created attachment 342205 [details] [review] build: Use AM_CPPFLAGS instead of INCLUDES INCLUDES is deprecated. This fixes an automake warning.
Created attachment 342206 [details] [review] tests: Disable g_type_init() calls for new GLib versions GLib deprecated g_type_init() with version 2.36.0, so we no longer need to call it. We require version 2.31.0, so keep the call for the intermediate versions.
Created attachment 342207 [details] [review] plparse: Remove an unused function if compiling without quvi This function is only used if compiling with quvi, so #ifdef it out otherwise to avoid an unused function warning from the compiler.
Created attachment 342208 [details] [review] plparse: Port from GSimpleAsyncResult to GTask GSimpleAsyncResult was deprecated in version 2.36 of GLib, and replaced by GTask. Bump our GLib dependency to 2.36 and start using GTask instead to avoid deprecated function warnings from the compiler.
Review of attachment 342204 [details] [review]: Obviously, this one should actually be squashed in before merging.
Review of attachment 342198 [details] [review]: I still don't like the amount of cut'n'paste between projects, but sure. ::: autogen.sh @@ +32,3 @@ + $srcdir/configure "$@" || exit 1 + + if [ "$1" = "--help" ]; then exit 0 else Weird indentation.
Review of attachment 342199 [details] [review]: Sure.
Review of attachment 342200 [details] [review]: Sure.
Review of attachment 342201 [details] [review]: Sure
Review of attachment 342202 [details] [review]: Sure
Review of attachment 342203 [details] [review]: Yes.
Review of attachment 342205 [details] [review]: Sure.
Review of attachment 342206 [details] [review]: Yep.
Review of attachment 342207 [details] [review]: This should probably be changed to work even without libquvi support. MatthieuDu worked on a youtube-dl based helper.
Review of attachment 342208 [details] [review]: > by GTask. Bump our GLib dependency to 2.36 and start using GTask instead Maybe do that after a branch, as you've added ifdef for g_type_init().
Attachment 342198 [details] pushed as 82c8dea - build: Update autogen.sh to latest GNOME recommendation Attachment 342199 [details] pushed as 400d233 - build: Add AX_IS_RELEASE macro Attachment 342200 [details] pushed as b4da777 - build: Port from GNOME_CODE_COVERAGE to AX_CODE_COVERAGE Attachment 342201 [details] pushed as 9b4c1f8 - build: Port from GNOME_DEBUG_CHECK to AX_CHECK_ENABLE_DEBUG Attachment 342202 [details] pushed as 7a6a6f0 - build: Drop use of GNOME_MAINTAINER_MODE_DEFINES Attachment 342203 [details] pushed as 0d0fd19 - build: Port from GNOME_COMPILE_WARNINGS to AS_COMPILER_FLAGS Attachment 342205 [details] pushed as 9a163bf - build: Use AM_CPPFLAGS instead of INCLUDES Attachment 342206 [details] pushed as 3f00f05 - tests: Disable g_type_init() calls for new GLib versions
Created attachment 342477 [details] [review] plparse: Enable videosite support even without quvi There are now other helper scripts apart from quvi, so the videosite support should not be conditionalised on quvi being available.
Review of attachment 342477 [details] [review]: We'd need to rejig a bit of that code to better handle no helper script being available though. Probably need to remove the hard-coded script path, and return an error if no script could be found.
(In reply to Bastien Nocera from comment #25) > Review of attachment 342477 [details] [review] [review]: > > We'd need to rejig a bit of that code to better handle no helper script > being available though. > Probably need to remove the hard-coded script path, and return an error if > no script could be found. Since I’m not working on things related to that at the moment (and hence can’t easily realistically test it), I would rather defer that until later. Perhaps we should go with attachment 342207 [details] [review]?
Created attachment 342869 [details] [review] plparse: Enable videosite support even without quvi There are now other helper scripts apart from quvi, so the videosite support should not be conditionalised on quvi being available.
Created attachment 342870 [details] [review] plparse: Port from GSimpleAsyncResult to GTask GSimpleAsyncResult was deprecated in version 2.36 of GLib, and replaced by GTask. Bump our GLib dependency to 2.36 and start using GTask instead to avoid deprecated function warnings from the compiler. Furthermore, as we are targetting GNOME 3.10 and later versions, and GNOME 3.10 shipped with GLib 2.38, we don't need to worry about leaving older versions in the dust.
Created attachment 342871 [details] [review] plparse: Enable videosite support even without quvi There are now other helper scripts apart from quvi, so the videosite support should not be conditionalised on quvi being available.
Attachment 342870 [details] pushed as 4566403 - plparse: Port from GSimpleAsyncResult to GTask Attachment 342871 [details] pushed as 9487256 - plparse: Enable videosite support even without quvi
Yay!
(In reply to Bastien Nocera from comment #21) > This should probably be changed to work even without libquvi support. > MatthieuDu worked on a youtube-dl based helper. Could you give some more details about this?
(In reply to Jeremy Bicha from comment #32) > (In reply to Bastien Nocera from comment #21) > > This should probably be changed to work even without libquvi support. > > MatthieuDu worked on a youtube-dl based helper. > > Could you give some more details about this? No, I can't. Please ask Matthieu.