After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775944 - Wrong introspection data for gst_event_new_select_streams and gst_event_parse_select_streams
Wrong introspection data for gst_event_new_select_streams and gst_event_parse...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.10.x
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-11 08:56 UTC by Iñaki García Etxebarria
Modified: 2016-12-15 09:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing the introspection data (1.17 KB, patch)
2016-12-14 06:00 UTC, Iñaki García Etxebarria 		committed Details | Review

Description Iñaki García Etxebarria 2016-12-11 08:56:39 UTC 
The list of streams arguments of gst_event_new_select_streams and gst_event_parse_select_streams (of type GLib*) are both annotated as (element-type gchar), but the proper annotation should be (element-type utf8), since afaict the elements of the GList are pointers to strings. (This is assuming that the stream ids are proper utf8, not sure if this is the case.)

This is affecting the Haskell bindings (and possibly any other statically typed bindings), see
https://github.com/haskell-gi/haskell-gi/issues/68
Comment 1 Tim-Philipp Müller 2016-12-11 10:02:32 UTC 
Makes sense. Are you planning on making a patch ? :)

Strings in GStreamer should always be UTF-8.
Comment 2 Iñaki García Etxebarria 2016-12-14 06:00:20 UTC 
Created attachment 341932 [details] [review]
Patch fixing the introspection data
Comment 3 Iñaki García Etxebarria 2016-12-14 06:00:39 UTC 
Sure, done! :)
Comment 4 Tim-Philipp Müller 2016-12-14 09:12:29 UTC 
Thanks, pushed:

commit 9cdacefa98c9feea77e21a9aca043c9354f2f69d
Author: Iñaki García Etxebarria <garetxe@gmail.com>
Date:   Wed Dec 14 06:56:55 2016 +0100

    g-i: Fix annotations for gst_event_new_select_streams() and gst_event_parse_select_streams()
    
    A gchar is not a string.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775944


(Should probably also be picked into 1.10 branch)
Comment 5 Iñaki García Etxebarria 2016-12-15 09:07:38 UTC 
Thanks!