GNOME Bugzilla – Bug 775817
rtph265pay: fix config-interval handling
Last modified: 2017-01-23 11:09:02 UTC
Created attachment 341620 [details] [review] Correct handling of config-interval=-1 When config-interval is set to -1 VPS/SPS/PPS should be inserted before IDR frames, but they are inserted before all NAL units in an access unit (the IDR frame can consist of several NAL unites) and before P-frames.
I think it was a mistake to not insert VPS/SPS/PPS before P-frames when config-interval > 0. I will update the patch later. The patch also makes sure VPS/SPS/PPS is not inserted between tiles when config_interval > 0, not just -1 like the commit message subject line reads.
Created attachment 342028 [details] [review] Correct handling of config-interval Same as last patch except it does not prevent instertion of VPS/SPS/PPS before P-frames when config-interval > 0.
Created attachment 343154 [details] [review] rtph265pay: Fix handling of config-interval Insert VPS/SPS/PPS before the first NAL unit containing an I-frame in an access unit only. If an access unit consists of several such NAL units (tiles) VPS/SPS/PPS should only be inserted before the first of them so that parameters are only updated between frames. Do not insert VPS/SPS/PPS before P-frames when config-interval is -1.
Review of attachment 343154 [details] [review]: Didn't review it yet, but does this make sure to only insert VPS/SPS/PPS if there is none right before the I frame?
(In reply to Sebastian Dröge (slomo) from comment #4) > Review of attachment 343154 [details] [review] [review]: > > Didn't review it yet, but does this make sure to only insert VPS/SPS/PPS if > there is none right before the I frame? It always inserts them if config-interval is not 0, just like rtph264pay. So if you have stream-format bytestream you should probably not set config-interval unless you want to duplicate VPS/SPS/PPS.
Just a reminder for myself, the diff should be read with "-w" to ignore all the whitespace. It's mostly indentation changes.
Attachment 343154 [details] pushed as 494246f - rtph265pay: Fix handling of config-interval