GNOME Bugzilla – Bug 775742
"make upload" just continues if hotdoc is not found
Last modified: 2016-12-08 07:41:59 UTC
$ make upload make: hotdoc: Command not found rsync -rvaz -e ssh --links --delete /home/slomo/Projects/gstreamer/head/gst-docs/built_doc/html/ gstreamer.freedesktop.org:/srv/gstreamer.freedesktop.org/public_html/documentation || /bin/true
I'm not sure if we can do much about this. If hotdoc is not installed, the Makefile won't include the hotdoc .mk file bit, so it makes no sense to rely on any of the hotdoc targets here. I guess we can check manually for hotdoc before proceeding? Mathieu, any better ideas?
Not really, I would only enable the upload rule `if ENABLE_DOCUMENTATION`, that ensures not only hotdoc is present, but also the other prerequisites as checked by the HOTDOC_CHECK macro.
Ah but we don't have a configure phase in there, right :) Well my suggestion would be to have one, or (even better) work on a meson module :)
Can't we just add a phony target that runs "hotdoc --help >/dev/null" and make all other relevant targets depends on that. If it is not present, it will just fail.
Guess that could work, doesn't seem like the cleanest solution to me though, mostly depends on the time one is willing to spend on this.
Pushed something like what Olivier suggested now. Could probably be improved, but seems to work. commit 40317e7bf35221ee8431a85d186495f5499c8f2a Author: Tim-Philipp Müller <tim@centricular.com> Date: Thu Dec 8 07:38:41 2016 +0000 Makefile: check for hotdoc before attempting upload https://bugzilla.gnome.org/show_bug.cgi?id=775742 I gather from your comments Mathieu that this or the meson part is not something you plan to work on, so closing the bug, otherwise please re-open.