After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775657 - TypeError: Gtk.Widget.hide_on_delete() takes exactly 1 argument (3 given)
TypeError: Gtk.Widget.hide_on_delete() takes exactly 1 argument (3 given)
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Subtitle Downloader plugin
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-12-05 18:58 UTC by gnome.vrb
Modified: 2016-12-06 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
opensubtitles: Call gtk_widget_hide_on_delete natively rather than via python. (1.99 KB, patch)
2016-12-05 19:01 UTC, gnome.vrb 		committed Details | Review

Description gnome.vrb 2016-12-05 18:58:26 UTC 
This happens when closing the "Download Movie Subtitles" dialog via [x] button. As a side effect, opening the dialog the second time gives an empty dialog, and crashes on click.
Comment 1 gnome.vrb 2016-12-05 19:01:54 UTC 
Created attachment 341424 [details] [review]
opensubtitles: Call gtk_widget_hide_on_delete natively rather than via python.

gtk_widget_hide_on_delete (widget) is not a callback function. Using
it as a callback function to "widget::delete-event" signal ( which
takes 3 args for callback ) in C code works, though this is not
correct. Python checks for argument count of callbacks, and so this
hack doesn't work for python code. So, we move it UI file to trigger
native callback.
Comment 2 Philip Withnall 2016-12-05 22:59:37 UTC 
That looks good, thanks. Pushed with a tweak to the commit message — please don’t end the summary line with a full stop.
Comment 3 Bastien Nocera 2016-12-06 09:45:21 UTC 
(In reply to Philip Withnall from comment #2)
> That looks good, thanks. Pushed with a tweak to the commit message — please
> don’t end the summary line with a full stop.

And put what it actually does in the subject line. This is something that we're supposed to be able to use in the NEWS file, which I clearly can't do in this case.