After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775651 - GdkX11-4.0.gir, GdkWin32-4.0.gir, and Gsk-4.0.gir are generated before Gdk-4.0.gir is ready
GdkX11-4.0.gir, GdkWin32-4.0.gir, and Gsk-4.0.gir are generated before Gdk-4....
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-12-05 17:51 UTC by fakey
Modified: 2016-12-05 18:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
require Gdk-4.0.gir before GdkX11-4.0.gir, GdkWin32-4.0.gir, and Gsk-4.0.gir (1.39 KB, patch)
2016-12-05 17:51 UTC, fakey
committed Details | Review

Description fakey 2016-12-05 17:51:32 UTC
Created attachment 341416 [details] [review]
require Gdk-4.0.gir before GdkX11-4.0.gir, GdkWin32-4.0.gir, and Gsk-4.0.gir

Nothing in gtk/Makefile.am prevents GdkX11-4.0.gir, GdkWin32-4.0.gir, and Gsk-4.0.gir from being g-ir-compiler'd before Gdk-4.0.gir. So parallel builds occasionally fail with:

make[3]: Entering directory '/home/william/.cache/jhbuild/build/gtk+/gtk'
  CCLD     libgtk-4.la
  GEN      Gdk-4.0.gir
  GEN      Gsk-4.0.gir
  GEN      GdkX11-4.0.gir
  GICOMP   Gsk-4.0.gir
  GICOMP   GdkX11-4.0.gir
./Gdk-4.0.gir:9:38: error: Error on line 5917 char 82: Document ended unexpectedly with elements still open - 'doc' was the last element opened
error parsing file GdkX11-4.0.gir: Failed to parse included gir Gdk-4.0
/home/william/.cache/jhbuild/install/share/gobject-introspection-1.0/Makefile.introspection:168: recipe for target 'GdkX11-4.0.typelib' failed
make[3]: *** [GdkX11-4.0.typelib] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/william/.cache/jhbuild/build/gtk+/gtk'
Makefile:2388: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/william/.cache/jhbuild/build/gtk+/gtk'
Makefile:719: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/william/.cache/jhbuild/build/gtk+'
Makefile:615: recipe for target 'all' failed
make: *** [all] Error 2
*** Error during phase build of gtk+: ########## Error running make -j 5  *** [1/1]
Comment 1 Emmanuele Bassi (:ebassi) 2016-12-05 18:04:46 UTC
Review of attachment 341416 [details] [review]:

LGTM