After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775553 - playback: Fix leak on select_streams
playback: Fix leak on select_streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.11.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-03 04:54 UTC by Seungha Yang
Modified: 2017-01-31 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playback: Fix leak on select_streams (1.91 KB, patch)
2016-12-03 04:56 UTC, Seungha Yang
committed Details | Review
decodebin3: Change return types of stream_in_{list,collection} (1.89 KB, patch)
2016-12-03 04:56 UTC, Seungha Yang
committed Details | Review
decodebin3: Change requested_selection to have its own memory for stream-id (4.57 KB, patch)
2016-12-03 04:57 UTC, Seungha Yang
committed Details | Review
decodebin3: Fix list leak on handle_stream_switch() (2.06 KB, patch)
2016-12-03 04:58 UTC, Seungha Yang
committed Details | Review

Description Seungha Yang 2016-12-03 04:54:25 UTC
Since gst_event_parse_select_streams() returns newly allocated
memory for stream-id(s), it should be freed explicitly.
Comment 1 Seungha Yang 2016-12-03 04:56:04 UTC
Created attachment 341293 [details] [review]
playback: Fix leak on select_streams
Comment 2 Seungha Yang 2016-12-03 04:56:38 UTC
Created attachment 341294 [details] [review]
decodebin3: Change return types of stream_in_{list,collection}
Comment 3 Seungha Yang 2016-12-03 04:57:13 UTC
Created attachment 341295 [details] [review]
decodebin3: Change requested_selection to have its own memory for stream-id
Comment 4 Seungha Yang 2016-12-03 04:58:48 UTC
Created attachment 341296 [details] [review]
decodebin3: Fix list leak on handle_stream_switch()
Comment 5 Edward Hervey 2017-01-31 15:48:53 UTC
commit e6ee68a34f22f2b66e289e8bfe8fbc620b7110fa
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sat Dec 3 13:38:28 2016 +0900

    decodebin3: Fix list leak on handle_stream_switch()
    
    Free no more used list variables
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775553

commit 44bc10219cfddc574f374824d6b7f12ca990074d
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sat Dec 3 13:22:54 2016 +0900

    decodebin3: Change requested_selection to have its own memory for stream-id
    
    "requested_selection" list might be generated by select-streams event.
    And memory of stream-id(s) in select-streams is independent from that of stream-collection.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775553

commit 30fe123fdb9845dec438b3c8c6c54eb3b8b03db2
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sat Dec 3 12:47:41 2016 +0900

    decodebin3: Change return types of stream_in_{list,collection}
    
    Change return types of functions to get memory address of stream-id.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775553

commit 10fe0497b2f989ed6e413d65dcc06b6ee3c539fe
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sat Dec 3 12:43:22 2016 +0900

    playback: Fix leak on select_streams
    
    Since gst_event_parse_select_streams() returns newly allocated
    memory for stream-id(s), it should be freed explicitly.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775553