Created attachment 341280 [details] [review]
check: Allow listing unit tests names

Anything against that?

It seems a bit weird to do that via an env var, wouldn't a command line option be better? Or is command line option problematic because not all main functions in tests use the macro?

(In reply to Tim-Philipp Müller from comment #3)
> It seems a bit weird to do that via an env var, wouldn't a command line
> option be better? Or is command line option problematic because not all main
> functions in tests use the macro?

Yes this is why I did not do it that way, also there is currently no option.
I guess I could change that though but I am not sure it is worth it, if you think it is I am fine making sure we use the macro everywhere and add options.

Created attachment 341842 [details] [review]
check: Allow listing unit tests names

Adding options while running gst_check_init

Looks fine to me, but does it work in the real world? :)

(In reply to Tim-Philipp Müller from comment #6)
> Looks fine to me, but does it work in the real world? :)

Surely not working otherwise it would be useless to add :P

I am using it so that we can use gst-validate-launcher and all its feature about getting backtraces and stuff to run our unit tests (and I actually run each test separately thanks to the feature added in that bz).

Let's get it in then and we can fix up any issues that come up.

I suspect some unit tests might have a custom main() that's why I'm asking.

(In reply to Tim-Philipp Müller from comment #8)
> Let's get it in then and we can fix up any issues that come up.
> 
> I suspect some unit tests might have a custom main() that's why I'm asking.

In the ones run on meson builds, it is all fine, basically in the custom main we need to call gst_check_init() before actually creating the testsuite, and then it works just fine (I already fixed it in the GES where it was not the case)

Attachment 341842 [details] pushed as f7255f3 - check: Allow listing unit tests names