After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775446 - generated code fails with -Werror=implicit-function-declaration
generated code fails with -Werror=implicit-function-declaration
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: general
0.34.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-01 07:09 UTC by Kalev Lember
Modified: 2016-12-02 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codegen: Add function-prototypes for all register-type calls (2.54 KB, patch)
2016-12-01 17:20 UTC, Rico Tzschichholz 		committed Details | Review

Description Kalev Lember 2016-12-01 07:09:43 UTC 
I'm building gnome-builder in rawhide where -Werror=implicit-function-declaration got enabled just yesterday. The gnome-builder build is failing in a generated .c file with:

vala-pack-plugin.c: In function 'peas_register_types':
vala-pack-plugin.c:117:2: error: implicit declaration of function 'ide_vala_completion_register_type' [-Werror=implicit-function-declaration]

The vala source for that is at https://git.gnome.org/browse/gnome-builder/tree/plugins/vala-pack/vala-pack-plugin.vala?h=GNOME_BUILDER_3_22_3
Comment 1 Rico Tzschichholz 2016-12-01 17:20:31 UTC 
Created attachment 341168 [details] [review]
codegen: Add function-prototypes for all register-type calls

Make sure to match the list of called register-type calls and include
implemented classes and interfaces.
Comment 2 Rico Tzschichholz 2016-12-01 22:04:06 UTC 
Attachment 341168 [details] pushed as 6f75088 - codegen: Add function-prototypes for all register-type calls
Comment 3 Kalev Lember 2016-12-02 09:00:36 UTC 
Thanks. I can confirm this fixes it for me.